-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V3.21.0 #42
V3.21.0 #42
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
Documentation on acceptable licenses can be found here. |
This reverts commit 1441d9c.
@conda-forge-admin, please rerende |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.08.09.13.48.36
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
For recipe:
Documentation on acceptable licenses can be found here. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
Documentation on acceptable licenses can be found here. |
The C++ library is built for MacOS X 12.0 and despite what the file name of the python wheel indicates, the C++ library in the wheel is also built for 12.0. So we might as well build the python module from source.
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.08.09.23.48.41
@conda-forge/core This package links against a binary only C++ library from bloomberg and if I understand the error messages correctly, this library is built for MacOS X 12.0. Hence the package build fails on OS X when we build for 10.9. Bloomberg also provides binary wheels for macos x, which the filename blpapi-3.21.0-cp39-cp39-macosx_10_9_x86_64.whl indicates should run on 10.9, but when I try to build the package from the wheel directly on OS X, the import test still gives an error that the bundled libblpapi3_64.so is built for MacOS X 12.0. This leads me to believe that the filename of the wheel is incorrect. Hence I tried building the python module from source on all platforms and bumping the Mac OS X dependency to 12.0. But then the build errors out because the Mac OS X 12.0 SDK is not available from phracker. Should I drop OS X support on this package or can we build against the 12.0 SDK? |
You can try a different SDK before dropping it: https://conda-forge.org/docs/maintainer/knowledge_base.html#requiring-newer-macos-sdks |
Thank you, do you mean I should try to bisect the oldest SDK the build will accept, even if the C++ library was built against the 12.0 SDK? |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.08.10.11.52.27
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.08.10.11.52.27
No idea. I never even held a mac on my hands. I'd try the same SDK and, if that doesn't work and the @conda-forge/blpapi team doesn't care about osx, I'd just drop it and open an issue to follow up later when someone with the expertise shows up. |
Ah thank you, then we are in similar situations with regard to macs. I just tried with the 11.0 and 11.3 SDKs and they still fail upon import with a missing symbol error and a note about how the C++ library was built against the 12.0 SDK. And let me just reiterate that attempting to build against the 12.0 SDK failed because newer SDKs than 11.3 are not available in the |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)I am sorry for opening multiple pull requests, I had problems rerendering so I tried deleting my fork and reforking.