update bazel to v2.0.0 #33
Conversation
rluria14
requested review from
abhi18av,
jjhelmus and
nehaljwani
as code owners
|
@conda-forge-admin, please re-render |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin, please re-render |
|
@jjhelmus @nehaljwani @abhi18av please review when you have a chance! |
|
@jjhelmus Has Anaconda Distribution moved to 10.12? |
We have not, our SDK target is 10.10 with a few cases where we still use 10.9 |
|
It seems that bazel can only be built with 10.12 SDK target on OSX. I've included the conda_build_config.yaml to set macosx_deployment_target to 10.12, re-rendered, and now it's passing. Also, for reference, it looks like qt-feedstock uses the 10.12 SDK target. |
|
@jjhelmus @nehaljwani bump |
recipe/meta.yaml
Outdated
|
|
||
| build: | ||
| number: 0 | ||
| ignore_prefix_files: True | ||
| binary_relocation: False | ||
| skip: True # [win] | ||
| missing_dso_whitelist: | ||
| - '*' |
There was a problem hiding this comment.
Can this be made more explicit? White listing everything (like is done here) essentially skips the under/overlinking check.
There was a problem hiding this comment.
@jjhelmus turns out missing_dso_whitelist was not needed so it's now removed from the recipe.
|
I'm not certain if this will work on CentOS 6 given that binaries embedded in the bazel self-extracting zip are dynamically linked to the conda provided libstdc++ and when unpacked will not have a correct RPATH. Still worth trying. |
|
@jjhelmus I do seem to be having a problem with the RPATH and libstdc++. Errors in build:
Any suggestions on how to fix this? |
In the recipe we use a Anaconda we statically link libstdc++ and libgcc. Unfortunately I have been able to get this to work on bazel >=0.27. |
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)