Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate aws_c_io0135 and aws_c_common083 #75

Closed
wants to merge 2 commits into from

Conversation

xhochy
Copy link
Member

@xhochy xhochy commented Oct 21, 2022

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member

h-vetinari commented Oct 24, 2022

99% tests passed, 2 tests failed out of 647

Total Test time (real) =  45.84 sec

The following tests FAILED:
	638 - h2_sm_acquire_stream (Failed)
	639 - h2_sm_acquire_stream_multiple_connections (Failed)

Unfortunately, this PR now blocks the openssl3 migration (through conda-forge/aws-c-s3-feedstock#125 -> aws-sdk-cpp -> arrow-cpp -> etc.; though realistically we could also rebuild aws-c-cal 0.5.19 for openssl 3, currently only 0.5.20 has it).

Normally I might advocate just skipping those 2 tests, but that depends how crucial we see HTTP2; stream acquisition is a pretty fundamental operation unfortunately...

First error I see in the trace is:

[DEBUG] [2022-10-21T15:14:03Z] [00000da4] [task-scheduler] - id=00000176EF134140: Running attempt_connection task with <Running> status
[DEBUG] [2022-10-21T15:14:03Z] [00000da4] [socket] - id=00000176EF132E10 handle=0000000000000258: initializing with domain 1 and type 0
[DEBUG] [2022-10-21T15:14:03Z] [00000da4] [socket] - id=00000176EF132E10 handle=0000000000000258: setting socket options to: keep-alive 0, keep idle 0, keep-alive interval 0, max failed probe count 0
[DEBUG] [2022-10-21T15:14:03Z] [00000da4] [socket] - id=00000176EF132E10 handle=0000000000000258: beginning connect.
[DEBUG] [2022-10-21T15:14:03Z] [00000da4] [socket] - id=00000176EF132E10 handle=0000000000000258: connecting to endpoint 2606:2800:220:1:248:1893:25c8:1946:443.
[TRACE] [2022-10-21T15:14:03Z] [00000da4] [event-loop] - id=00000176EF11B160: subscribing to events on handle 0000000000000258
[TRACE] [2022-10-21T15:14:03Z] [00000da4] [socket] - id=00000176EF132E10 handle=0000000000000258: connection pending, scheduling timeout task
[TRACE] [2022-10-21T15:14:03Z] [00000da4] [event-loop] - id=00000176EF11B160: scheduling task 00000176EF135540 in-thread for timestamp 731046631800
[DEBUG] [2022-10-21T15:14:03Z] [00000da4] [task-scheduler] - id=00000176EF135540: Scheduling (null) task for future execution at time 731046631800
[TRACE] [2022-10-21T15:14:03Z] [00000da4] [event-loop] - id=00000176EF11B160: detected more scheduled tasks with the next occurring at 731046631800, using timeout of 9999.
[TRACE] [2022-10-21T15:14:03Z] [00000da4] [event-loop] - id=00000176EF11B160: waiting for a maximum of 9999 ms
[TRACE] [2022-10-21T15:14:03Z] [00000da4] [event-loop] - id=00000176EF11B160: wake up with 1 events to process.
[TRACE] [2022-10-21T15:14:03Z] [00000da4] [event-loop] - id=00000176EF11B160: invoking handler.
[TRACE] [2022-10-21T15:14:03Z] [00000da4] [socket] - static: connect completion triggered on event-loop 00000176EF11B160
[TRACE] [2022-10-21T15:14:03Z] [00000da4] [socket] - id=00000176EF132E10 handle=0000000000000258: connect completion triggered. Socket has not timed out yet: proceeding with connection
[ERROR] [2022-10-21T15:14:03Z] [00000da4] [socket] - id=00000176EF132E10 handle=0000000000000258: connect completion triggered with error -1073741252
[ERROR] [2022-10-21T15:14:03Z] [00000da4] [socket] - id=00000176EF132E10 handle=0000000000000258: connection error with code 1049
[DEBUG] [2022-10-21T15:14:03Z] [00000da4] [channel-bootstrap] - id=00000176EF0E0060: client connection on socket 00000176EF132E10 completed with error 1049.
[DEBUG] [2022-10-21T15:14:03Z] [00000da4] [channel-bootstrap] - id=00000176EF0E0060: recording bad address 2606:2800:220:1:248:1893:25c8:1946.

@xhochy
Copy link
Member Author

xhochy commented Oct 24, 2022

Unfortunately, this PR now blocks the openssl3 migration (through conda-forge/aws-c-s3-feedstock#125 -> aws-sdk-cpp -> arrow-cpp -> etc.; though realistically we could also rebuild aws-c-cal 0.5.19 for openssl 3, currently only 0.5.20 has it).

It would be OK to rebuild aws-c-cal 0.5.19 with openssl3. I will probably rebuild aws-c-io 0.13.4 also for the new aws-c-common to minimise the diff to better understand the failure.

@h-vetinari
Copy link
Member

I will probably rebuild aws-c-io 0.13.4 also for the new aws-c-common to minimise the diff to better understand the failure.

Actually, I think that's what's necessary. I may have misread the error in conda-forge/aws-c-s3-feedstock#125

The reported errors are:
- Encountered problems while solving:
-   - package aws-c-io-0.13.4-h2f1bd44_4 requires aws-c-cal >=0.5.19,<0.5.20.0a0, but none of the providers can be installed

At least, rerendering https://github.com/conda-forge/aws-c-cal-feedstockon the new v0.5.19 branch doesn't generate any changes.

@xhochy
Copy link
Member Author

xhochy commented Oct 24, 2022

aws-c-common was separately migrated, let's wait for a fresh PR for aws-c-io

@xhochy xhochy closed this Oct 24, 2022
@xhochy xhochy deleted the aws_c_io0135-aws_c_common083 branch October 24, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants