Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable gandiva on osx-arm, unpin PPC compilers #848

Merged
merged 9 commits into from
Sep 13, 2022
Merged

Enable gandiva on osx-arm, unpin PPC compilers #848

merged 9 commits into from
Sep 13, 2022

Conversation

h-vetinari
Copy link
Member

@h-vetinari h-vetinari commented Sep 10, 2022 •
edited
Loading

Some follow-ups after the recent migrations

Closes #849

@conda-forge-linter
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member Author

@conda-forge-admin, please rerender

@h-vetinari
Copy link
Member Author

@pitrou
I've tried to unpin the very old GCC on PPC, but this runs into a myriad of errors of the following kind when trying to assemble libgandiva.so:

[clone .localalias]: error: relocation overflow

Are you aware where this might be coming from or what the reason/solution might be?

@h-vetinari
Copy link
Member Author

Also, it seems osx-arm is not yet ready to remove the almost 2 year old work-arounds for jemalloc/mimalloc...

@h-vetinari h-vetinari changed the title Enable gandiva on osx-arm, unpin PPC compilers, bump google-cloud-cpp Enable gandiva on osx-arm, bump google-cloud-cpp Sep 12, 2022
This was referenced Sep 12, 2022
Closed
Merged
@h-vetinari h-vetinari changed the title Enable gandiva on osx-arm, bump google-cloud-cpp Enable gandiva on osx-arm Sep 12, 2022
@h-vetinari h-vetinari force-pushed the refresh branch 3 times, most recently from 9a852f5 to a9c8d0b Compare September 13, 2022 07:50
@h-vetinari
Copy link
Member Author

@conda-forge-admin, please rerender

@xhochy
Copy link
Member

xhochy commented Sep 13, 2022

@pitrou I've tried to unpin the very old GCC on PPC, but this runs into a myriad of errors of the following kind when trying to assemble libgandiva.so:

[clone .localalias]: error: relocation overflow

Are you aware where this might be coming from or what the reason/solution might be?

This could be related to the -fplt/-fno-plt flag. We should look into this in a separate PR though

xhochy
xhochy reviewed Sep 13, 2022
View reviewed changes
recipe/build-arrow.sh Outdated Show resolved Hide resolved
@xhochy
Copy link
Member

xhochy commented Sep 13, 2022

This could be related to the -fplt/-fno-plt flag.

Yeah, that was the culprit in LLVM, but the errors looked quite different AFAIR.

I have seen quite a lot of different messages related to this in nodejs. I would first play around with this flag before investigating anything else.

@h-vetinari h-vetinari force-pushed the refresh branch 2 times, most recently from 0846c71 to 5d41b5b Compare September 13, 2022 16:45
@h-vetinari
Copy link
Member Author

@conda-forge-admin, please rerender

@conda-forge conda-forge deleted a comment from github-actions bot Sep 13, 2022
@h-vetinari
Copy link
Member Author

h-vetinari commented Sep 13, 2022 •
edited
Loading

I have seen quite a lot of different messages related to this in nodejs. I would first play around with this flag before investigating anything else.

Good guess, that was the solution! 🥳

Meanwhile, I've figured out osx-arm + gandiva too, so this PR can basically unfold its full formerly intended glory 😋

@h-vetinari h-vetinari changed the title Enable gandiva on osx-arm Enable gandiva on osx-arm, unpin PPC compilers Sep 13, 2022
xhochy
xhochy approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@h-vetinari
Copy link
Member Author

Nice

Better double-check what I just force-pushed a few seconds before your review, but I'm confident it is identical.

@h-vetinari h-vetinari mentioned this pull request Sep 13, 2022
Merged
This was referenced Sep 13, 2022
Closed
Merged
@h-vetinari
Copy link
Member Author

OK, there was no change here for linux-aarch, and the rest is green (or failing spuriously), so merging. 🙃

@h-vetinari h-vetinari merged commit 62d8896 into conda-forge:main Sep 13, 2022
@h-vetinari h-vetinari deleted the refresh branch September 13, 2022 21:59
This was referenced Sep 14, 2022
Merged
Merged
kou added a commit to apache/arrow that referenced this pull request Oct 31, 2022
@h-vetinari @kou
ARROW-17635: [Python][CI] Sync conda recipe with the arrow-cpp feedst…
9d060aa 
…ock (#14102)

Corresponds to status of feedstock as of conda-forge/arrow-cpp-feedstock#848, minus obvious & intentional divergences in the setup here (with the exception of unpinning xsimd, which was [pinned](https://github.com/apache/arrow/blob/apache-arrow-9.0.0/cpp/cmake_modules/ThirdpartyToolchain.cmake#L2245) as of 9.0.0, but isn't anymore).

Lead-authored-by: H. Vetinari <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
kou added a commit to apache/arrow that referenced this pull request Nov 15, 2022
@h-vetinari @kou
ARROW-17635: [Python][CI] Sync conda recipe with the arrow-cpp feedst…
82cf616 
…ock (#14102)

Corresponds to status of feedstock as of conda-forge/arrow-cpp-feedstock#848, minus obvious & intentional divergences in the setup here (with the exception of unpinning xsimd, which was [pinned](https://github.com/apache/arrow/blob/apache-arrow-9.0.0/cpp/cmake_modules/ThirdpartyToolchain.cmake#L2245) as of 9.0.0, but isn't anymore).

Lead-authored-by: H. Vetinari <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhochy xhochy xhochy approved these changes

@cpcloud cpcloud Awaiting requested review from cpcloud cpcloud is a code owner

@jakirkham jakirkham Awaiting requested review from jakirkham jakirkham is a code owner

@jreback jreback Awaiting requested review from jreback jreback is a code owner

@kou kou Awaiting requested review from kou kou is a code owner

@kszucs kszucs Awaiting requested review from kszucs kszucs is a code owner

@leifwalsh leifwalsh Awaiting requested review from leifwalsh leifwalsh is a code owner

@nealrichardson nealrichardson Awaiting requested review from nealrichardson nealrichardson is a code owner

@pcmoritz pcmoritz Awaiting requested review from pcmoritz pcmoritz is a code owner

@pearu pearu Awaiting requested review from pearu pearu is a code owner

@pitrou pitrou Awaiting requested review from pitrou pitrou is a code owner

@robertnishihara robertnishihara Awaiting requested review from robertnishihara robertnishihara is a code owner

@siddharthteotia siddharthteotia Awaiting requested review from siddharthteotia siddharthteotia is a code owner

@wesm wesm Awaiting requested review from wesm wesm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unpin very old GCC on PPC
3 participants
@h-vetinari @conda-forge-linter @xhochy