-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable CUDA support [READY] #125
Conversation
…onda-forge-pinning 2020.03.14
…onda-forge-pinning 2020.03.14
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
For recipe:
|
…onda-forge-pinning 2020.03.20
@pearu, your idea is a good one, but this is how you should implement it. |
@isuruf ok, I'll fix to using 9.2. Two questions:
|
Yes, it looks like arrow is using only the CUDA driver API. @xhochy should confirm. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
@conda-forge-admin, please rerender |
Other packages are using a mutex package. |
It's hard to change stuff in the future. Get it right first, otherwise people will complain. That said, we can have both. We can have the build string in it and users who want to use the mutex package can do so. We should also have a look at the name. |
No objections to keeping both. Edit: Agree it would be nice to have the name align. Other packages currently do |
…onda-forge-pinning 2020.04.17.01.00.32
I have fixed merged conflicts and renamed @isuruf @jakirkham please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @pearu! Thanks again for working on this 😄
Had some suggestions below that might simplify the syntax a bit and drop some things we don't need. Nothing critical though.
…onda-forge-pinning 2020.04.18.00.00.57
…onda-forge-pinning 2020.04.18.00.00.57
Hi all, could we have this PR merged? |
Several projects using CUDA rely on arrow-cpp 0.16 and packaging those are currently blocked by this PR. |
LGTM. Thanks for your work on this @pearu! 😄 |
Hi all -- thanks for doing this work @pearu and to everyone else for reviewing. We just pushed out a new version of OmniSciDB which uses Arrow 0.16 and are interested in seeing this patch merged so we can push our python connector changes as well. Is there a rough ETA? |
FWIW this issue may be relevant. |
Checklist
conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)