Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update activation failure warning #1130

Closed
wants to merge 2 commits into from
Closed

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Jul 28, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@maresb
Copy link
Contributor Author

maresb commented Jul 28, 2023

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/arrow-cpp-feedstock/actions/runs/5696050108.

@h-vetinari
Copy link
Member

Thanks for the PR! :)
As I said in h-vetinari#1, I'll just fold this into the next batch of PRs. I don't think it's worth an extra build on its own.

@maresb
Copy link
Contributor Author

maresb commented Jul 28, 2023

Agreed, thanks!

@maresb maresb closed this Jul 28, 2023
@maresb
Copy link
Contributor Author

maresb commented Jul 28, 2023

Oh... maybe I shouldn't have closed this if you wanted the placeholder / test verification? Please reopen if you want.

@h-vetinari
Copy link
Member

Oh... maybe I shouldn't have closed this if you wanted the placeholder / test verification? Please reopen if you want.

It's already in #1124. ;-)

@maresb maresb deleted the patch-1 branch July 29, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants