Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with opentelemetry support (on unix) #1048

Merged
merged 3 commits into from
Jan 23, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions .azure-pipelines/azure-pipelines-linux.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ libgoogle_cloud_storage_devel:
- '2.34'
libgrpc:
- '1.67'
libopentelemetry_cpp:
- '1.18'
libprotobuf:
- 5.28.3
libutf8proc:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ libgoogle_cloud_storage_devel:
- '2.34'
libgrpc:
- '1.67'
libopentelemetry_cpp:
- '1.18'
libprotobuf:
- 5.28.3
libutf8proc:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ libgoogle_cloud_storage_devel:
- '2.34'
libgrpc:
- '1.67'
libopentelemetry_cpp:
- '1.18'
libprotobuf:
- 5.28.3
libutf8proc:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ libgoogle_cloud_storage_devel:
- '2.34'
libgrpc:
- '1.67'
libopentelemetry_cpp:
- '1.18'
libprotobuf:
- 5.28.3
libutf8proc:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ libgoogle_cloud_storage_devel:
- '2.34'
libgrpc:
- '1.67'
libopentelemetry_cpp:
- '1.18'
libprotobuf:
- 5.28.3
libutf8proc:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ libgoogle_cloud_storage_devel:
- '2.34'
libgrpc:
- '1.67'
libopentelemetry_cpp:
- '1.18'
libprotobuf:
- 5.28.3
libutf8proc:
Expand Down
2 changes: 2 additions & 0 deletions .ci_support/osx_64_.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ libgoogle_cloud_storage_devel:
- '2.34'
libgrpc:
- '1.67'
libopentelemetry_cpp:
- '1.18'
libprotobuf:
- 5.28.3
libutf8proc:
Expand Down
2 changes: 2 additions & 0 deletions .ci_support/osx_arm64_.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ libgoogle_cloud_storage_devel:
- '2.34'
libgrpc:
- '1.67'
libopentelemetry_cpp:
- '1.18'
libprotobuf:
- 5.28.3
libutf8proc:
Expand Down
24 changes: 12 additions & 12 deletions README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion recipe/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ cmake -GNinja \
-DARROW_WITH_BZ2=ON \
-DARROW_WITH_LZ4=ON \
-DARROW_WITH_NLOHMANN_JSON=ON \
-DARROW_WITH_OPENTELEMETRY=${READ_RECIPE_META_YAML_WHY_NOT} \
-DARROW_WITH_OPENTELEMETRY=ON \
-DARROW_WITH_SNAPPY=ON \
-DARROW_WITH_UCX=OFF \
-DARROW_WITH_ZLIB=ON \
Expand Down
15 changes: 6 additions & 9 deletions recipe/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ source:
folder: cpp/submodules/parquet-testing

build:
number: 4
number: 5
# for cuda support, building with one version is enough to be compatible with
# all later versions, since arrow is only using libcuda, and not libcudart.
skip: true # [cuda_compiler_version not in ("None", cuda_compiler_version_min)]
Expand Down Expand Up @@ -73,9 +73,6 @@ requirements:
- azure-storage-files-datalake-cpp # [unix]
- brotli
- bzip2
# not yet: https://github.com/conda-forge/cpp-opentelemetry-sdk-feedstock/issues/38
# - cpp-opentelemetry-sdk
# - proto-opentelemetry-proto =={{ cpp_opentelemetry_sdk }}
- gflags
- glog
# arrow uses a customized jemalloc, see #944
Expand All @@ -85,6 +82,8 @@ requirements:
- libgoogle-cloud-devel
- libgoogle-cloud-storage-devel
- libgrpc
# see https://github.com/apache/arrow/issues/45033
- libopentelemetry-cpp # [unix]
- libprotobuf
- libutf8proc
- lz4-c
Expand Down Expand Up @@ -192,8 +191,7 @@ outputs:
- {{ pin_subpackage("libarrow", max_pin="x.x") }}
ignore_run_exports_from:
- {{ compiler("cuda") }} # [cuda_compiler_version != "None"]
# arrow only uses headers on osx/win, apparently
- gflags # [not linux]
- gflags
# shared lib linked on unix, not on win
- glog # [win]
ignore_run_exports:
Expand All @@ -220,16 +218,15 @@ outputs:
- azure-storage-files-datalake-cpp # [unix]
- brotli
- bzip2
# not yet: https://github.com/conda-forge/cpp-opentelemetry-sdk-feedstock/issues/38
# - cpp-opentelemetry-sdk
# - proto-opentelemetry-proto =={{ cpp_opentelemetry_sdk }}
- gflags
- glog
# arrow uses a customized jemalloc, see #944
# - jemalloc
- libabseil
- libgoogle-cloud-devel
- libgoogle-cloud-storage-devel
- libopentelemetry-cpp # [unix]
- libprotobuf
- libutf8proc
- lz4-c
- orc
Expand Down