Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid installing vegafusion 2rc #58

Merged
merged 5 commits into from
Nov 21, 2024
Merged

Conversation

joelostblom
Copy link
Contributor

@joelostblom joelostblom commented Nov 18, 2024

There was a new 2.0 RC of vegafusion published yesterday, which is not compatible with the current release of altair, so we need to avoid installing it as a dependency.

CC @jonmmease to confirm

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@joelostblom
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ It looks like the 'altair-all' output doesn't have any tests.
  • ℹ️ PyPI default URL is now pypi.org, and not pypi.io. You may want to update the default source url.

@jonmmease
Copy link
Contributor

Thanks @joelostblom! I was expecting that conda solvers wouldn't pull in the RC automatically, were you seeing this happen? Either way, adding the upper bound now is great.

@joelostblom
Copy link
Contributor Author

A few of my students installed altair-all today and they ended up with Vegafusion 2.0, so I believe conda is pulling in the RC when looking at the dependencies to install.

@joelostblom
Copy link
Contributor Author

@ocefpaf I'm unsure why the tests are failing here. Do you know if it is a CI-related issue and we can merge anyways, or is it something that should be fixed in this PR?

@jonmmease
Copy link
Contributor

The error makes it look like the test is being run with python 3.13 (See vega/altair#3620 (comment)). I just tried adding a version constraint on python itself.

@jonmmease
Copy link
Contributor

That did it, we need to remember to drop the constraint once 3.13 is supported. Merging and opening an issue.

@jonmmease jonmmease merged commit adfd437 into conda-forge:main Nov 21, 2024
4 checks passed
@joelostblom
Copy link
Contributor Author

Great, thank you Jon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants