-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for CUDA 12 + PyTorch 2.4 #15
Rebuild for CUDA 12 + PyTorch 2.4 #15
Conversation
The transition to CUDA 12 SDK includes new packages for all CUDA libraries and build tools. Notably, the cudatoolkit package no longer exists, and packages should depend directly on the specific CUDA libraries (libcublas, libcusolver, etc) as needed. For an in-depth overview of the changes and to report problems [see this issue]( conda-forge/conda-forge.github.io#1963 ). Please feel free to raise any issues encountered there. Thank you! 🙏
…nda-forge-pinning 2024.08.20.23.21.46
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Seeing the following error on CI:
Would drop these lines as aihwkit-gpu-feedstock/recipe/meta.yaml Line 41 in 3c2f64d
aihwkit-gpu-feedstock/recipe/meta.yaml Line 53 in 3c2f64d
That should fix CI |
…nda-forge-pinning 2024.08.26.01.37.21
Cleaning this up fixes CUDA 12 and works with CUDA 11: * In CUDA 11, this is added by the CUDA compiler * In CUDA 12, this package doesn't exist
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
|
@conda-forge-admin , please re-render |
…nda-forge-pinning 2024.08.30.04.04.42
Looks like the build needs cuBLAS /home/conda/feedstock_root/build_artifacts/aihwkit-gpu_1724992663380/work/src/rpucuda/cuda/cuda_util.h:24:10: fatal error: cublas_v2.h: No such file or directory
24 | #include "cublas_v2.h"
| ^~~~~~~~~~~~~ |
- libcublas-dev # [(cuda_compiler_version or "").startswith("12")] | ||
- libcurand-dev # [(cuda_compiler_version or "").startswith("12")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added based on these #include
s
recipe/meta.yaml
Outdated
- cuda-version {{ cuda_compiler_version }} # [cuda_compiler_version != "None"] | ||
- libcublas-dev # [(cuda_compiler_version or "").startswith("12")] | ||
- libcurand-dev # [(cuda_compiler_version or "").startswith("12")] | ||
- libcusparse-dev # [(cuda_compiler_version or "").startswith("12")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed due to ATen usage, which comes from PyTorch that in turn needs cuSPARSE
recipe/meta.yaml
Outdated
- cuda-version {{ cuda_compiler_version }} # [cuda_compiler_version != "None"] | ||
- libcublas-dev # [(cuda_compiler_version or "").startswith("12")] | ||
- libcurand-dev # [(cuda_compiler_version or "").startswith("12")] | ||
- libcusolver-dev # [(cuda_compiler_version or "").startswith("12")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another ATen dependency
Also add comments for clarity.
…cf-autotick-bot/rebuild-cuda120-0-3_h709134
This is passing! 🥳 @kkvtran could you please review? 🙂 Also if it looks good, please feel free to merge |
This PR has been triggered in an effort to update cuda120.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
Here are some more details about this specific migrator:
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/10481143886 - please use this URL for debugging.