-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test warnings with setuptools-based get_info #92
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
I didn't see any |
It does seem to me like the issue has been solved! 😅 But in order to properly check for warnings regarding the loading of BLAS, it looks like I need to also import I just added that import so that we can check if the warning is triggered on other platforms. (Nope, all good ✔️) Next I think we can remove Then we need to make sure we get to the root cause of that warning... or simply discontinue pypy 3.7 support, since pypy 3.8 and 3.9 are now supported on Conda-Forge. (I could start that migration if you'd like, but one thing at a time...) |
This looks really good to me from the perspective of the warnings. I think the problem is solved. Regarding |
This has been cherry-picked into #95. |
Thanks to the contributors for their efforts in addressing the issue. Now it works well on my windows. |
Check for warnings as per aesara-devs/aesara#980 (comment)
The warnings are already in
allowed-warnings-*.txt
, so we have to check the Windows CI logs.Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)