Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add m2w64 compilers for windows #29

Merged
merged 12 commits into from
Aug 18, 2021
Merged

Add m2w64 compilers for windows #29

merged 12 commits into from
Aug 18, 2021

Conversation

twiecki
Copy link
Contributor

@twiecki twiecki commented Aug 18, 2021

It seems like currently we are not installing the right compilers for windows.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@twiecki
Copy link
Contributor Author

twiecki commented Aug 18, 2021

@conda-forge-admin please rerender

conda-forge-linter and others added 2 commits August 18, 2021 10:17
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [39, 40]

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@twiecki
Copy link
Contributor Author

twiecki commented Aug 18, 2021

@conda-forge-admin, please rerender

@twiecki
Copy link
Contributor Author

twiecki commented Aug 18, 2021

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

@twiecki
Copy link
Contributor Author

twiecki commented Aug 18, 2021

@conda-forge-admin, please rerender

@twiecki twiecki removed the request for review from ericmjl August 18, 2021 13:54
Copy link
Member

@brandonwillard brandonwillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this! I don't know what the situation is with these Windows dependencies, so I can't really say what's correct or not; however, it seems like the PyPy builds are failing, and that makes sense given our non-trivial dependencies and direct use of CPython-based extensions.

In other words, I don't know if we should be running PyPy tests in the first place.

recipe/meta.yaml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants