Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark libarrow* 16.1.0 as broken #996

Merged
merged 3 commits into from
May 15, 2024

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented May 15, 2024

The arrow feedstock has run exports set up to allow runtime versions to float between minor versions within the same major family. Arrow did not release any minor versions between 1.0 and 16.0, only major and patch versions, so this export was never leveraged. However, the 16.1 release of revealed that this run export is not valid because arrow libraries are versioned such that different minor versions are not ABI-compatible, so libraries compiled against 16.0 will not be able to use 16.1 at runtime (and vice versa). The recipe is being fixed in conda-forge/arrow-cpp-feedstock#1409

Guidelines for marking packages as broken:

  • We prefer to patch the repo data (see here)
    instead of marking packages as broken. This alternative workflow makes environments more reproducible.
  • Packages with requirements/metadata that are too strict but otherwise work are
    not technically broken and should not be marked as such.
  • Packages with missing metadata can be marked as broken on a temporary basis
    but should be patched in the repo data and be marked unbroken later.
  • In some cases where the number of users of a package is small or it is used by
    the maintainers only, we can allow packages to be marked broken more liberally.
  • We (conda-forge/core) try to make a decision on these requests within 24 hours.

What will happen when a package is marked broken?

  • Our bots will add the broken label to the package. The main label will remain on the package and this is normal.
  • Our bots will rebuild our repodata patches to remove this package from the repodata.
  • In a few hours after the anaconda.org CDN picks up the new patches, you will no longer be able to install the package from the main channel.

Checklist:

  • I want to mark a package as broken (or not broken):

    • Added a description of the problem with the package in the PR description.
    • Pinged the team for the package for their input.
  • I want to archive a feedstock:

    • Pinged the team for that feedstock for their input.
    • Make sure you have opened an issue on the feedstock explaining why it was archived.
    • Linked that issue in this PR description.
    • Added links to any other relevant issues/PRs in the PR description.
  • I want to request (or revoke) access to an opt-in CI resource:

    • Pinged the relevant feedstock team(s)
    • Added a small description explaining why access is needed

@vyasr vyasr requested a review from a team as a code owner May 15, 2024 22:34
@vyasr
Copy link
Contributor Author

vyasr commented May 15, 2024

ping @conda-forge/arrow-cpp

@h-vetinari
Copy link
Member

Can you please sort the entries? It's hard to see if it's complete

@h-vetinari h-vetinari changed the title Add broken yaml file Mark libarrow* 16.1.0 as broken May 15, 2024
@h-vetinari
Copy link
Member

Also you're missing libparquet 16.1.0, which is the only one that has a name not starting with "libarrow"

@vyasr
Copy link
Contributor Author

vyasr commented May 15, 2024

What sort order do you want? Right now there's a top-level sort by the library (e.g. all of libarrow, then all of libarrow-all, etc). Within each library it's ordered by the platform (basically the ordering visible on the anaconda package websites).

Good catch on parquet, just added it.

@vyasr
Copy link
Contributor Author

vyasr commented May 15, 2024

I've resorted the packages by alphabetical order, then within each package sorted the different builds alphabetically as well. I've also added a newline between packages so that it's hopefully easier to see the group.

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this help with readability?

Agree we are testing the limits of comprehension with these package removals. Might be time to rethink how this is done (though not necessarily in this PR)

@@ -0,0 +1,100 @@
action: broken
packages:
- linux-64/libarrow-16.1.0-he216f8a_0_cuda.conda
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- linux-64/libarrow-16.1.0-he216f8a_0_cuda.conda
# libarrow
- linux-64/libarrow-16.1.0-he216f8a_0_cuda.conda

- win-64/libarrow-16.1.0-h107e38f_0_cpu.conda
- win-64/libarrow-16.1.0-h1a9115d_0_cuda.conda

- linux-64/libarrow-all-16.1.0-ha770c72_0_cpu.conda
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- linux-64/libarrow-all-16.1.0-ha770c72_0_cpu.conda
# libarrow-all
- linux-64/libarrow-all-16.1.0-ha770c72_0_cpu.conda

- win-64/libarrow-all-16.1.0-h57928b3_0_cpu.conda
- win-64/libarrow-all-16.1.0-h57928b3_0_cuda.conda

- linux-64/libarrow-acero-16.1.0-h530483c_0_cuda.conda
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- linux-64/libarrow-acero-16.1.0-h530483c_0_cuda.conda
# libarrow-acero
- linux-64/libarrow-acero-16.1.0-h530483c_0_cuda.conda

- win-64/libarrow-acero-16.1.0-he0c23c2_0_cpu.conda
- win-64/libarrow-acero-16.1.0-he0c23c2_0_cuda.conda

- linux-64/libarrow-dataset-16.1.0-h530483c_0_cuda.conda
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- linux-64/libarrow-dataset-16.1.0-h530483c_0_cuda.conda
# libarrow-dataset
- linux-64/libarrow-dataset-16.1.0-h530483c_0_cuda.conda

- win-64/libarrow-dataset-16.1.0-he0c23c2_0_cpu.conda
- win-64/libarrow-dataset-16.1.0-he0c23c2_0_cuda.conda

- linux-64/libarrow-flight-16.1.0-hc0a3844_0_cuda.conda
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- linux-64/libarrow-flight-16.1.0-hc0a3844_0_cuda.conda
# libarrow-flight
- linux-64/libarrow-flight-16.1.0-hc0a3844_0_cuda.conda

- win-64/libarrow-flight-16.1.0-ha7f4a34_0_cpu.conda
- win-64/libarrow-flight-16.1.0-ha7f4a34_0_cuda.conda

- linux-64/libarrow-flight-sql-16.1.0-h3de2799_0_cuda.conda
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- linux-64/libarrow-flight-sql-16.1.0-h3de2799_0_cuda.conda
# libarrow-flight-sql
- linux-64/libarrow-flight-sql-16.1.0-h3de2799_0_cuda.conda

- win-64/libarrow-flight-sql-16.1.0-hdeef14f_0_cpu.conda
- win-64/libarrow-flight-sql-16.1.0-hdeef14f_0_cuda.conda

- linux-64/libarrow-gandiva-16.1.0-h35c4161_0_cpu.conda
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- linux-64/libarrow-gandiva-16.1.0-h35c4161_0_cpu.conda
# libarrow-gandiva
- linux-64/libarrow-gandiva-16.1.0-h35c4161_0_cpu.conda

- win-64/libarrow-gandiva-16.1.0-hd4515a1_0_cpu.conda
- win-64/libarrow-gandiva-16.1.0-hd4515a1_0_cuda.conda

- linux-64/libarrow-substrait-16.1.0-h11d00a1_0_cuda.conda
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- linux-64/libarrow-substrait-16.1.0-h11d00a1_0_cuda.conda
# libarrow-substrait
- linux-64/libarrow-substrait-16.1.0-h11d00a1_0_cuda.conda

- win-64/libarrow-substrait-16.1.0-h1f0e801_0_cpu.conda
- win-64/libarrow-substrait-16.1.0-h1f0e801_0_cuda.conda

- linux-64/libparquet-16.1.0-h6a7eafb_0_cpu.conda
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- linux-64/libparquet-16.1.0-h6a7eafb_0_cpu.conda
# libparquet
- linux-64/libparquet-16.1.0-h6a7eafb_0_cpu.conda

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@h-vetinari h-vetinari merged commit 9f8b812 into conda-forge:main May 15, 2024
1 check passed
@vyasr vyasr deleted the fix/mark_arrow161_broken branch May 15, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants