Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pkgconfig metadata on windows #51

Merged
merged 6 commits into from
Oct 31, 2022
Merged

Conversation

h-vetinari
Copy link
Member

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari h-vetinari force-pushed the pkg branch 5 times, most recently from 0a14144 to 09654f5 Compare October 21, 2022 22:25
@h-vetinari h-vetinari marked this pull request as ready for review October 21, 2022 22:25
@h-vetinari
Copy link
Member Author

@conda-forge/abseil-cpp @hmaarrfk This PR has the intention to be able to switch on a compilation test for grpc, which ends up needing correct pkgconfig metadata, which is a bit tricky for shared builds on windows.

There are two different levels here - shared builds result in only abseil_dll.dll & absl_flags_*.lib on windows, but packages consuming abseil are used to having way more targets (that - only on windows, of course - are all bunched into the abseil_dll for the shared build).

Hence the minimal effort to get correct metadata would be to add pkgconfig/abseil_dll.pc and abseil_flags_*.pc, but that would mean that any consuming package that's not taking care of this distinction would have to patch the pkgconfig metadata (example).

Therefore I think it'd be nicer if we just created the whole suite of absl_*.pc files, but point them to abseil_dll (avoiding the need to patch downstream), which is what this PR does. I've added tests for correctness of pkgconfig & CMake integrations, and am planning to try to upstream this after things work out also in e.g. grpc.

Thoughts?

@xhochy
Copy link
Member

xhochy commented Oct 28, 2022

Sounds like a reasonable approach 👍

@h-vetinari
Copy link
Member Author

Thanks @xhochy !

@hmaarrfk @isuruf
Any thoughts / objections?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate pkg-config metadata on windows, resp. abseil_dll
3 participants