Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten co-installability of new builds #42

Merged
merged 2 commits into from
Aug 31, 2022
Merged

Conversation

h-vetinari
Copy link
Member

Fix oversight from #35

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor

isn't the whole point to allow

  • Package a depend on abseil V2 (shared)
  • Package b depends on abseil V1 (static) AND a

How can one build package b now?

@h-vetinari
Copy link
Member Author

isn't the whole point to allow [...]

Not for abseil, because the ABIs differ (shared is C++17, static may be C++11 / C++14). If one of your deps depends on shared abseil, you have to use shared abseil as well, or move to C++17 (in which case you can also use the static lib again, see this PR).

But feel free to join into a serendipitously timed discussion that concerns this: #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants