Use ECR without AwsAccessKeyId and AwsSecretAccessKey #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
william-tran
force-pushed
the
wtran/ecr-assumed-role
branch
from
926602a to
bdd6148
Compare
|
Nice to see somebody else had the same issue as me :) I also raised a few last week to fix this: #96 I went with using an explicit parameter to get the resource to authenticate to ECR rather than relying on the region being set. Not sure which solution is preferable? |
This allows ECR to be used if a role is already assumed. Fixes #94 Signed-off-by: Will Tran <[email protected]>
william-tran
force-pushed
the
wtran/ecr-assumed-role
branch
from
bdd6148 to
82c8af0
Compare
william-tran
changed the title
|
Sorry, but I can't merge this change - see #96 (comment) for an explanation. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows ECR to be used if a role is already assumed. Fixes #94