Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for passing build flags #213

Closed
wants to merge 1 commit into from

Conversation

gcmalloc
Copy link
Contributor

@gcmalloc gcmalloc commented Jul 2, 2018

this allow to pass flags to the docker build command such as --pull, --squash or --compress.
Addresses #157.

Sorry for the noise on #212

@vito
Copy link
Member

vito commented Aug 22, 2018

Sorry for the delay on this, and thanks for submitting it, but I think this falls under our kitchen sink config anti-pattern and adds risk of breaking people's pipelines in the future as we refactor the resource.

If there are build flags you still need passed, it'd make more sense to add them as explicit params - it'll be much safer to support going forward.

Side note: I'm also wary of adding new features here in light of concerns raised in #190 - I think in the future we'll be heading closer to something like Kaniko and concourse/rfcs#7.

Thanks again!

@vito vito closed this Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants