breaking ECR change coming - changes needed?

[bacoboy]

Opening this issue up in case there are pre-emptive changes to make regarding this email I recieved from AWS. I assume this just means using the latest SDK/ecr-credentials-helper

Hello,

We wanted to let you know about an upcoming change to the 'docker login' command that may affect how you authenticate with ECR via the AWS CLI. In Docker v17.06, launching in June 2017, the -e and --email flags will no longer be accepted when executing 'docker login' [1]. The ECR 'get-login' command in the AWS CLI returns a 'docker login' command that you can execute to login to an ECR registry. By default, the -e flag is included in the output of 'get-login'. To remove this flag from the output, we are adding a new option to 'get-login' called --no-include-email. This new option will be available in the AWS CLI as of version 1.11.91 expected to be released on 05/23/2017. Here is an example output for ‘get-login’ with this change:

$ aws ecr get-login
docker login -u AWS -p -e none https://<aws_account_id>.dkr.ecr..amazonaws.com
$ aws ecr get-login --no-include-email
docker login -u AWS -p https://<aws_account_id>.dkr.ecr..amazonaws.com

If you are currently using ‘get-login’ to authenticate with ECR, Please take the following actions based on the Docker version you are running:
• If you are running Docker v17.06 or higher, you must update the AWS CLI to version 1.11.91 or higher. Additionally, you must change any reference to 'get-login' to include the new --no-include-email option.
• If you are running Docker v17.06 or lower, no action is required since these versions accept the email flags. By default, the 'get-login' command will continue to include the -e flag in the output to preserve backwards compatibility with older versions of Docker.

For more information regarding these changes please see the AWS CLI GitHub issue [2]. If you have any questions, please reach out to us via the ECS forum page [3].

Please note, you may consider using the ecs-cli [4] or the Amazon ECR Credential Helper [5] as alternatives to using the ‘get-login’ command to login to ECR. Both of these options use your IAM access keys to directly authenticate with ECR providing a more seamless login experience.

[1] https://docs.docker.com/engine/deprecated/#e-and---email-flags-on-docker-login
[2] aws/aws-cli#1926
[3] https://forums.aws.amazon.com/forum.jspa?forumID=187&start=0
[4] https://github.com/aws/amazon-ecs-cli
[5] https://github.com/awslabs/amazon-ecr-credential-helper

Sincerely,
Amazon Web Services

Somebody already asked a similar question over there: awslabs/amazon-ecr-credential-helper#36

[chendrix]

Doesn't look like any changes are necessary.