Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating for email flag. Will this affect amazon-ecr-credential-helper? #36

Closed
daviddyball opened this issue May 24, 2017 · 4 comments

Comments

@daviddyball
Copy link

Just got an email from the AWS team warning of incompatibilities with awscli's ecr get-login command and the upcoming docker 17.06 version that will deprecate the --email flag originally part of docker login.

Will this have a knock-on affect to this project?

@samuelkarp
Copy link
Contributor

The credential helper should not be affected by this change, but please let us know if you run into any problems.

@colin-mcdonald
Copy link

This is causing issues for me...basically aws ecr get-login returns a docker-login command that has -e none flag set (which is the shorthand for --email). Because of this I manually have to delete the -e none each time to run it.

I also see a new warning when I execute the command returned from aws ecr get-login which does not prevent execution:
WARNING! Using --password via the CLI is insecure. Use --password-stdin.

@samuelkarp
Copy link
Contributor

@colin-mcdonald Please file issues with the AWS CLI against the AWS CLI GitHub repo.

@rpnguyen
Copy link

@colin-mcdonald You'll need to call aws ecr get-login --no-include-email. See this forum post for more context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants