-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STORYQ-2 Refactor #34
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scytacki
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me.
I left a couple of comments that you can take or leave.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIra story: https://concord-consortium.atlassian.net/browse/STORYQ-2
This is a major refactor of StoryQ. I spent several days diving deep into the code, cleaning things up as I encountered them. There are many changes, many of which I won't include in this write up. But here are the high level objectives and changes:
any
types from the codebase. There are a few exceptions to this that I didn't have time to fix, mostly related tocodap-helper.ts
andCodapInterface.ts
and a few.js
files.anys
were related to codap API requests and responses. I addedcodap-api-types.ts
to address these. There must be a better way! If we don't already have one, we should try to release a library with API types.slate
in the plugin, just to access its basic types.object
or things like{ [index: string]: string}
were used, but it's very possible I missed some.ifs
, objects, imports, etc.