[pkg_config][PkgConfigDeps] Checking PC files creation order #10344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franramirez688
commented
Jan 14, 2022
| @@ -492,18 +492,18 @@ def package_info(self): | |||
| self.cpp_info.components["cmp3"].set_property("pkg_config_name", "libpkg") | |||
| """) | |||
| client.save({"conanfile.py": conanfile}) | |||
| client.run("create . pkgB/1.0@") | |||
| client.run("create . pkgb/1.0@") | |||
There was a problem hiding this comment.
To lowercase, to avoid failures in Conan 2.0
memsharded
approved these changes
Jan 17, 2022
czoido
approved these changes
Jan 17, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Testing the expected PC files created when the component name matches with the root package one using either
pkg_configorPkgConfigDepsgenerators.Closes: #10341
Docs: conan-io/docs#2378
developbranch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.