-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgraded to importlib #10127
upgraded to importlib #10127
Conversation
Great! 😄 Be aware of the pre 3.7.0 bug in invalidate_cache tho! |
Thanks for the pointer to https://github.com/conan-io/conan/pull/6633/files#diff-c15f4aacf65aa58b31a041bac63e4dd7337355d9ec44a8f32b2a5815d5eb5ea9R210 But I have some questions:
Thanks! |
It's been quite a long time since then, so I may miss the fine details, sorry about that. I'm pretty sure the only reasoning to branch them out was the core issue of the lack of invalidation of the "negative cache". At the time it was "either a small-scope hack or a conventional tool" for the same purpose. I think before opt-in to either there must be a clear understanding of use-cases where it does help. The issue at the time was specifically with cache reuse inside a single Python invocation, a call to user code in the middle that introduces cache side-effects like |
Ok I see. I think the best would be to write some tests when the As this is already looking as some progress, I'd probably don't wait to merge it till then, I think this could be merged asap. |
Includes the
invalidate_caches()
callClose #4687
Close #3441
Close #6633
@Minimonium this should address previous concerns about python loading, note
invalidate_caches()
is called in the constructor ofConanFileLoader()
, a new one will be created with eachConanApp()
which is now explicitly created inside eachapi
call, so I'd say we are ok now.