Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate CentOS 6 #236

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Conversation

uilianries
Copy link
Member

@uilianries uilianries commented Dec 11, 2020

Another distro reached EOL and I didn't find an old-releases equivalent for CentOS6. This situation is bad, because now we can't update our images based on CentOS, making other PRs broken.

My idea is deprecate Cent OS 6 on this PR, and open a new one replacing by Cent OS 7.

Cent OS 6 uses glibc 2.12
Cent OS 7 uses glibc 2.17

/cc @ericLemanissier

UPDATE:

  • Add CentOS 7 is no longer needed, as CCI (official) doesn't use those images, only based on Ubuntu.
  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've followed the Best Practices guides for Dockerfile.

Signed-off-by: Uilian Ries <[email protected]>
Croydon added a commit to bincrafters/bincrafters-package-tools that referenced this pull request Dec 14, 2020
Copy link
Contributor

@Croydon Croydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we actually want to add another CentOS based image. I think in the long-term it would be awesome if we could build our compilers ourselves (hello GCC and LLVM Conan packages!) and then choose an actively supported LTS distro as a base image for all containers.

The huge advantage for CentOS was the old glibc versions, making binaries compatible with pretty much every supported distribution, but we don't use it in CCI anyway and I just migrated Bincrafters away from it too

@Croydon Croydon mentioned this pull request Dec 14, 2020
5 tasks
@uilianries
Copy link
Member Author

I'm not sure if we actually want to add another CentOS based image. I think in the long-term it would be awesome if we could build our compilers ourselves (hello GCC and LLVM Conan packages!) and then choose an actively supported LTS distro as a base image for all containers.

The huge advantage for CentOS was the old glibc versions, making binaries compatible with pretty much every supported distribution, but we don't use it in CCI anyway and I just migrated Bincrafters away from it too

Same feeling. We don't use for CCI too, the only propose would be for community, but we don't want to maintain it we don't use directly. Indeed, adding compiler packages is the future IHMO.

@uilianries uilianries merged commit 55375ef into conan-io:master Dec 15, 2020
@uilianries uilianries deleted the hotfix/centos6-gcc7 branch December 15, 2020 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants