Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ci complete #19

Merged
merged 8 commits into from
Oct 30, 2017
Merged

Feature/ci complete #19

merged 8 commits into from
Oct 30, 2017

Conversation

lasote
Copy link
Contributor

@lasote lasote commented Oct 30, 2017

No description provided.

uilianries and others added 6 commits June 1, 2017 09:58
- FIX: Added assert to verify each call system result

Signed-off-by: Uilian Ries <[email protected]>
- Added docker suite to build, test and deploy by python script

Signed-off-by: Uilian Ries <[email protected]>
- New scripts and variables were introduced in README
- Changed default user to lasote in Travis file

Signed-off-by: Uilian Ries <[email protected]>
- Created simple script to build, test and deploy
- Improved script description in README

Signed-off-by: Uilian Ries <[email protected]>
- Docker should run without sudo

Signed-off-by: Uilian Ries <[email protected]>
@lasote
Copy link
Contributor Author

lasote commented Oct 30, 2017

It fails because of #17. As I commented we can do two things:

  • Forget about the old 7.1 and only support 7.2 (and the latest if it keeps happening the same), so the already uploaded images (7.1 in this case) will be there but only "frozen" and with no maintenance anymore, only binary support, no more Dockerfile, no more possibility of an upgrade.
  • Try to force somehow the distribution to install 7.1 or downgrade, I've done it in the past with some other images, but it requires time to do it.

@uilianries @ovidiub13 WDYT? I think we should provide the 7.1 somehow.

@uilianries
Copy link
Member

I prefer the first one.

We have a bunch of images to maintain and in many it's a headache try fix distro environment. But my opinion is, we will spend to much effort to fix just another version, meanwhile we should care about 7.2 because it's the latest.

Also, we could provide a table in README file with all images status (build and life cycle).

@madpipeline
Copy link
Contributor

@lasote What's the purpose of these images?

  • To provide what the disto offers + conan, or do we need a specific compiler? If the latter there are official GCC Docker images based on Debian. They also skip 7.1.
  • To provide specific tools that we consider common, and make it easier for users?

Getting the Ubuntu folks to also ship 7.1 will be rather difficult.

@lasote
Copy link
Contributor Author

lasote commented Oct 30, 2017

Ok. I've talked with @memsharded and it makes sense since >5 where gcc minor is like a patch of <5. Probably we will take into consideration for conan/settings too. We are thinking about it.

@lasote
Copy link
Contributor Author

lasote commented Oct 30, 2017

Related with: @ovidiub13 conan-io/conan#1214
So we are deprecating the 7.1 image as you proposed. Probably we will do something with the conan settings, probably it makes no much sense to keep using the minor version by default for gcc 7.
@memsharded is opening an issue in conan repository.

| [lasote/conangcc62: gcc 6.2](https://hub.docker.com/r/lasote/conangcc62/) | Supported |
| [lasote/conangcc63: gcc 6.3](https://hub.docker.com/r/lasote/conangcc63/) | Supported |
| [lasote/conangcc71: gcc 7.1](https://hub.docker.com/r/lasote/conangcc71/) | DEPRECATED, only frozen binary image support, No Dockerfile |
| [lasote/conangcc72: gcc 7.2](https://hub.docker.com/r/lasote/conangcc72/) | Supported |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@lasote lasote merged commit 66507d1 into master Oct 30, 2017
@uilianries uilianries deleted the feature/CI_complete branch March 12, 2019 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants