Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use xenial for GCC4.9 #177

Closed
wants to merge 2 commits into from

Conversation

uilianries
Copy link
Member

@uilianries uilianries commented Jan 23, 2020

Since Conan Center Index is using GCC5 for building installer packages, most of them won't work with package with are built with GCC 4.9 due the Ubuntu version used in the docker image which is Trusty (14.04).

Updating the base images to xenial (16.04) will solve that problem, however, as side effect, some users that are still running trusty will find the same compatibility error.

IMO I don't see people asking for GCC 4.x anymore, so I presume any side effect will be minimal or even for companies which prefer building packages from sources.

An example of this problem: https://github.com/bincrafters/conan-glib/pull/13/checks?check_run_id=404903770

The project glib requires meson/0.53.0, which was built on xenial by gcc5. As it's an installer package, compiler is not part of its ID, thus the result is an error due the glibc version.

Changelog: Fix: 4.9 now is compatible with GCC 5

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've followed the Best Practices guides for Dockerfile.

Signed-off-by: Uilian Ries <[email protected]>
@uilianries uilianries requested review from SSE4, jgsogo and danimtb January 23, 2020 13:14
@ericLemanissier
Copy link
Contributor

Isn't this the kind of change which would break the ABI between binaries created with old image (wily) and new image (xenial) ?

@uilianries
Copy link
Member Author

@ericLemanissier Yes, it will break. However, we can re-generate all GCC 4.9 packages. Also, do you remember any case where people asked for GCC 4.x ? The problem here is that CCI will break some packages due glic version in Xenial.

@ericLemanissier
Copy link
Contributor

I personally don't care about GCC 4.x, and I don't recall specific requests about it
I think all the conan docker tools image should be based on the same distribution as CCI for the same compiler version, otherwise it makes it impossible to combine CCI binaries with binaries compiled on conan docker tools images.

@uilianries
Copy link
Member Author

I think all the conan docker tools image should be based on the same distribution as CCI for the same compiler version, otherwise it makes it impossible to combine CCI binaries with binaries compiled on conan docker tools images.

I agree. CCI is running these docker images, so we can "fix" that problem. I would like to use the same distro for any compiler, but is more complicated, since we don't have all them available for a same distro version.

@uilianries
Copy link
Member Author

/cc @Croydon

@Croydon
Copy link
Contributor

Croydon commented Jan 23, 2020

I'm guessing this could be fine for now

For the long-term we need a better strategy how to handle glibc compatibility. Relying on end-of-life Ubuntu versions can't be the answer

Signed-off-by: Uilian Ries <[email protected]>
@Croydon
Copy link
Contributor

Croydon commented Feb 25, 2020

Friendly ping @jgsogo @danimtb

Many CI pipelines for GCC 4.9 are broken since we started moving installer packages to CCI. Unbreaking them would be nice 😄

@ericriff
Copy link

Is this going to get merged?

@uilianries
Copy link
Member Author

@ericriff No. We have a new propose: #204

@uilianries uilianries closed this Jun 16, 2020
@uilianries uilianries deleted the hotfix/gcc49-glibc branch November 4, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants