- [kmod] add 29

[SSE4]

for: #8555
closes: #8557

Specify library name and version: kmod/29

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!

---

• I've read the guidelines for contributing.
• I've followed the PEP8 style guides for Python code in the recipes.
• I've used the latest Conan client version.
• I've tried at least one configuration locally with the
  conan-center hook activated.

[SSE4]

some workarounds for conan-io/conan#10640 & conan-io/conan#10341
in 1.44, libzstd.pc recursively references itself:

$ cat /home/conan/.conan/data/kmod/29/_/_/build/e7842461bbcd29441fdb340a5299c019eae366ea/libzstd.pc
Name: libzstd
Description: Conan package: libzstd
Version: 1.5.2
Requires: libzstd

[jgsogo]

Please, add a TODO or something similar in the recipe source itself, so we know that these lines should be removed after some bug is fixed in Conan.

Thanks!

[SSE4]

okay, I have added, just in case

[SpaceIm]

So except for zstd issue in its pc file, is AutotoolsDeps needed since all dependencies are discovered by PKG_CHECK_MODULES?

https://github.com/kmod-project/kmod/blob/v29/configure.ac#L86-L128

Why do we need to manually inject PKG_CONFIG_PATH, while CMakeToolchain handles CMAKE_MODULE_PATH/CMAKE_PREFIX_PATH out of the box? Seems to be a lack of consistency.

[SSE4]

see conan-io/conan#10639, we need AutotoolsDeps to set PKG_CONFIG_PATH, as well as other variables to workaround conan bugs (in particular, conan-io/conan#10640 & conan-io/conan#10341)
at the moment of writing a recipe, it wasn't decided who and how (automatically or manually) will set PKG_CONFIG_PATH.

[SpaceIm]

Suggested change

	self.run(os.path.join(self._source_subfolder, "autogen.sh"))
	self.run(os.path.join(self._source_subfolder, "autogen.sh"))

libtool & pkgconf should be added to build requirements. autogen.sh call autoreconf... but also gtkdocize which may not be available.

https://github.com/kmod-project/kmod/blob/v29/autogen.sh#L9-L10

Why not just call autoreconf manually to have full control of what happen, like we do usually?

[SSE4]

in their readme, they say to launch autogen.sh, I just followed their build instructions.
gtkdocize seems to be fully optional (I don't build any docs).
libtool/pkgconf seems to be already available in docker images, but we can add explicit build_requirements for the completeness, as it's harmless (and will benefit users who will build on pure environment).

[SpaceIm]

If you run autogen.sh, gtkdocize is not optional anymore. My advice is to never run any autogen.sh script, regardless of upstream readme, but ensure to run our own autoreconf. libtool & pkgconf must be added to build requirements because you don't know whether folks have libtool or pkg-config installed.

[SSE4]

as I can see, it's fully optional, e.g. autogen.sh prints:

source_subfolder/autogen.sh: 9: gtkdocize: not found

and then build continues and finishes successfully.
never mind, I've added explicit call to autoreconf

[SSE4]

I've also added libtool/pkgconf for completeness. it's the old good discussion on what to add to the build_requires, and what to assume as a ground base (or add to the profile, but not to the recipe). e.g. we assume that cmake should be already available on the developer's system, as well as binutils and coreutils, and the compiler itself, of course. it really only depends on where do you want to mark a border, and I am personally fine with libtool/pkgconf as build requirements.

[jgsogo]

there are too many FIXMEs in my opinion, but we need to start using these new generators... so let's see how it goes as we switch to new Conan versions

[conan-center-bot]

All green in build 2 (9fd5592a8322ef8774d83d9dfda59fa2887680d9):

• kmod/29@:
  All packages built successfully! (All logs)