-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libffi/3.2.1] / [libffi/3.3]Make a patch for 3.2.1 and 3.3 to pull the latest config.guess/config.sub to support aarch64 (M1 macs) #5085
Conversation
This comment has been minimized.
This comment has been minimized.
Oh boy, the recipe size is too big... I'm pulling changes to one big file and creating not one but two patches, each 120KB in size. I don't see any way of going around that... @SSE4 any thoughts please? Well I guess I see one way: do not patch the 3.2.1... only the 3.3. I'm going to try this in 6bf631a |
maybe limit 256K is too small and not reasonable, so we should adjust it... |
Test on an M1 mac mini
Before
Build log, building libffi/3.3 from master(py39)irvinemac@all (master=)$ conan create . libffi/3.3@ -b missing
[HOOK - conan-center.py] post_export(): [CONANDATA.YML REDUCE (KB-H031)] OK libffi/3.3: WARN: The package libffi/3.3:8fafab5ebfba468fd21a497cfee65cafe294bd9e doesn't belong to the installed recipe revision, removing folder Installing (downloading, building) binaries... [HOOK - conan-center.py] post_source(): [LIBCXX MANAGEMENT (KB-H011)] OK
----Running------
checking build system type... arm-apple-darwin20.3.0 ----Running------
/Library/Developer/CommandLineTools/usr/bin/make all-recursive ----Running------
Making install in include ----Running------
-- The C compiler identification is AppleClang 12.0.0.12000032
-- Build files have been written to: /Users/irvinemac/git/conan/conan-center-index/recipes/libffi/all/test_package/build/06788ff71b0efa6d28472f37ac096c14ff4f7493 ----Running------
[ 50%] Building C object CMakeFiles/test_package.dir/test_package.c.o After
Build log, building libffi/3.3 from this branch(py39)irvinemac@all (master=)$ conan create . libffi/3.3@ -b missing [HOOK - conan-center.py] pre_export(): [DEPRECATED GLOBAL CPPSTD (KB-H001)] OK
[HOOK - conan-center.py] post_export(): [CONANDATA.YML REDUCE (KB-H031)] OK libffi/3.3 (test package): Installing package Installing (downloading, building) binaries... [HOOK - conan-center.py] post_source(): [LIBCXX MANAGEMENT (KB-H011)] OK
----Running------
checking build system type... aarch64-apple-darwin20.3.0 ----Running------
/Library/Developer/CommandLineTools/usr/bin/make all-recursive ----Running------
Making install in include ----Running------
-- The C compiler identification is AppleClang 12.0.0.12000032
-- Build files have been written to: /Users/irvinemac/git/conan/conan-center-index/recipes/libffi/all/test_package/build/06788ff71b0efa6d28472f37ac096c14ff4f7493 ----Running------
[ 50%] Building C object CMakeFiles/test_package.dir/test_package.c.o ----Running------
print_int(13) |
This comment has been minimized.
This comment has been minimized.
Could you cleanup this patch? Almost 5000 lines 🤯 How can we review? Is it not possible to patch |
I pulled the latest of these two files from current libffi master is all. As you can see, this PR is also huge: libffi/libffi#576
|
Is it an error that you mention zlib in the PR title and description ? |
@ericLemanissier Sorry, I must have been distracted. I retitled with libffi |
This comment has been minimized.
This comment has been minimized.
|
What about a virtual release? is that possible? |
conan-center-index has |
it should work, as long as |
if you mean do an unofficial |
|
Yeah, there's 82 commits since the last release mostly CI changes... might be worth doing a Personally, the patch is just way too big and I am not familiar enough to review but hopefully the other ideas pan out |
@jmarrec
If the |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
6bf631a
to
37f4878
Compare
@madebr Sorry, I've been swamped and It fell down in my list of recent notifications. I'm trying it out now |
This comment has been minimized.
This comment has been minimized.
Super to hear this! |
Googling for |
It was something we were trying to reproduce in CCI (it happened before) to confirm our hypothesis: conan-io/conan#8519 (comment) |
ping @SSE4 , he will be glad to hear everything related to M1. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
yes, I am already aware about this fix :) |
@memsharded @jmarrec @danimtb This commit breaks cross-compilation, |
@PengZheng , yes, that approach would be more aligned with current Conan releases regarding two-profile approach. You can open the PR yourself. Thanks for noticing. |
closes: #4059
Specify library name and version: libffi/3.2.1, libffi/3.3
@SSE4 identified the changes upstream by finding libffi/libffi#576 . Retrieved
config.guess
andconfig.sub
versions from libffi/libffi@95ef857conan-center hook activated.