-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gmp: bump + enable building static libraries on MSVC #3836
Conversation
config.yml syntax error in build 1:
|
4c8e49e
to
8704c0b
Compare
Some configurations of 'gmp/6.1.2' failed in build 2 (
|
"6.2.0": | ||
folder: all | ||
"6.2.1": | ||
folder: all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"6.2.0": | |
folder: all | |
"6.2.1": | |
folder: all | |
"6.2.1": | |
folder: all | |
"6.2.0": | |
folder: all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it work adding 6.2.0
... maybe justy keep the point release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I add 6.2.1 in this pr.
This comment was just about ordering the versions in descending order.
"lt_cv_sys_global_symbol_pipe=cat", # added to get further in shared MSVC build, but it gets stuck later | ||
]) | ||
self._autotools.flags.append("-FS") | ||
# self._autotools.cxx_flags.append("-EHsc") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# self._autotools.cxx_flags.append("-EHsc") |
All green in build 3 (
|
I detected other pull requests that are modifying gmp recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
# INFO: According to the gmp readme file, make check should not be omitted, but it causes timeouts on the CI server. | ||
if self.options.run_checks: | ||
autotools.make(args=["check"]) | ||
# INFO: According to the gmp readme file, make check should not be omitted, but it causes timeouts on the CI server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏴
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is correct.
The tests are run in the build context.
The checks are also disabled by default, so there will be no timeouts.
@SpaceIm @uilianries @gocarlos @Croydon |
self.build_requires("msys2/20200517") | ||
if self.settings.compiler == "Visual Studio": | ||
self.build_requires("yasm/1.3.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why only for Visual Studio? Is it not also required for all platforms if disable_assembly=False
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other platforms can just use the gnu assembler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By using yasm, this also means that for the moment only x86 and x86_64 architectures are supported on MSVC.
Maybe it is possible to combine the GNU assembler (from binutils) with MSVC, but that's something I did not test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so LGTM
* master: (73 commits) (conan-io#3878) opengl: support FreeBSD (conan-io#3882) [system-cci] Fix hooks (conan-io#3881) [szip] Fix hooks (conan-io#3880) [tcl] Fix hooks (conan-io#3866) xorg: add freebsd packages (conan-io#3825) Adds baikal-p7 5.6 (conan-io#3758) minimal recipe for pciutils/3.7.0 (conan-io#3211) added recipe for extra-cmake-modules (conan-io#3870) tl: fix compiler version check again (conan-io#3865) bump eigen/3.3.9 (conan-io#3864) add functionalplus/0.2.13-p0 bump fmt/7.1.3 (conan-io#3694) (conan-io#3858) fix: zulu-openjdk package info (conan-io#3836) gmp: bump + enable building static libraries on MSVC (conan-io#3812) Add logr v0.1.0 (conan-io#3786) add Open62541 recipe v1.0.3 and v1.1.3 (conan-io#3696) openh264: refactor + add 2.1.1 release (conan-io#3607) add botan/2.17.2 (conan-io#3854) Add PEGTL 3.0.0 (conan-io#3859) bump spdlog/1.8.2 ...
Specify library name and version: gmp/all
conan-center hook activated.