Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gmp: bump + enable building static libraries on MSVC #3836

Merged
merged 2 commits into from
Dec 14, 2020

Conversation

madebr
Copy link
Contributor

@madebr madebr commented Dec 10, 2020

Specify library name and version: gmp/all

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

config.yml syntax error in build 1:

Only one library can be changed in the same PR: [gmp/all, mpc/all]|

@conan-center-bot
Copy link
Collaborator

Some configurations of 'gmp/6.1.2' failed in build 2 (8704c0b19d282e33dc10e6606ce6b6a2dc744dc1):

Comment on lines 2 to +5
"6.2.0":
folder: all
"6.2.1":
folder: all
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"6.2.0":
folder: all
"6.2.1":
folder: all
"6.2.1":
folder: all
"6.2.0":
folder: all

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it work adding 6.2.0 ... maybe justy keep the point release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I add 6.2.1 in this pr.
This comment was just about ordering the versions in descending order.

"lt_cv_sys_global_symbol_pipe=cat", # added to get further in shared MSVC build, but it gets stuck later
])
self._autotools.flags.append("-FS")
# self._autotools.cxx_flags.append("-EHsc")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# self._autotools.cxx_flags.append("-EHsc")

@conan-center-bot
Copy link
Collaborator

All green in build 3 (e7737e69ac9a812fa15be0cbb534b46e8c05bd4d)! 😊

@ghost
Copy link

ghost commented Dec 10, 2020

I detected other pull requests that are modifying gmp recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

# INFO: According to the gmp readme file, make check should not be omitted, but it causes timeouts on the CI server.
if self.options.run_checks:
autotools.make(args=["check"])
# INFO: According to the gmp readme file, make check should not be omitted, but it causes timeouts on the CI server.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏴

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is correct.
The tests are run in the build context.
The checks are also disabled by default, so there will be no timeouts.

@madebr
Copy link
Contributor Author

madebr commented Dec 11, 2020

@SpaceIm @uilianries @gocarlos @Croydon
Please review. Thanks!

@SSE4 SSE4 requested a review from uilianries December 11, 2020 07:43
self.build_requires("msys2/20200517")
if self.settings.compiler == "Visual Studio":
self.build_requires("yasm/1.3.0")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only for Visual Studio? Is it not also required for all platforms if disable_assembly=False?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other platforms can just use the gnu assembler.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By using yasm, this also means that for the moment only x86 and x86_64 architectures are supported on MSVC.
Maybe it is possible to combine the GNU assembler (from binutils) with MSVC, but that's something I did not test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so LGTM

@conan-center-bot conan-center-bot merged commit dee2861 into conan-io:master Dec 14, 2020
@madebr madebr deleted the gmp_bump_msvc branch December 14, 2020 06:47
cacay added a commit to cacay/conan-center-index that referenced this pull request Dec 15, 2020
* master: (73 commits)
  (conan-io#3878) opengl: support FreeBSD
  (conan-io#3882) [system-cci] Fix hooks
  (conan-io#3881) [szip] Fix hooks
  (conan-io#3880) [tcl] Fix hooks
  (conan-io#3866) xorg: add freebsd packages
  (conan-io#3825) Adds baikal-p7 5.6
  (conan-io#3758) minimal recipe for pciutils/3.7.0
  (conan-io#3211) added recipe for extra-cmake-modules
  (conan-io#3870) tl: fix compiler version check again
  (conan-io#3865) bump eigen/3.3.9
  (conan-io#3864) add functionalplus/0.2.13-p0
  bump fmt/7.1.3 (conan-io#3694)
  (conan-io#3858) fix: zulu-openjdk package info
  (conan-io#3836) gmp: bump + enable building static libraries on MSVC
  (conan-io#3812) Add logr v0.1.0
  (conan-io#3786) add Open62541 recipe v1.0.3 and v1.1.3
  (conan-io#3696) openh264: refactor + add 2.1.1 release
  (conan-io#3607) add botan/2.17.2
  (conan-io#3854) Add PEGTL 3.0.0
  (conan-io#3859) bump spdlog/1.8.2
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants