Add Cppcheck 2.2 #3424

mjvankampen · 2020-11-05T09:53:30Z

Specify library name and version: cppcheck/2.2

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

Deprecates https://github.com/bincrafters/conan-cppcheck_installer

I removed the z3 option as the original z3 (https://github.com/Z3Prover/z3/blob/master/cmake/Z3Config.cmake.in) provides some definitions that the conan z3 recipe does not provide, while cppcheck uses them. The best way to solve this is to add these to the z3 conan package right?

conan-center-bot · 2020-11-05T10:06:57Z

All green in build 1 (18cc73d32825d312beb81aa235c7006d73c0a12f)! 😊

cppcheck/2.2: Generated 68 packages. All logs here

It improves cppcheck reliability greatly

conan-center-bot · 2020-11-05T10:35:59Z

Some configurations of 'cppcheck/2.2' failed in build 2 (f8fe968c2722b951877b813793c3b85c50b67f01):

Windows x86_64, Release, Visual Studio 16, MT
Access to all the logs

The conan generated z3 package file does not provide the cmake definitions that cppcheck expects: https://github.com/Z3Prover/z3/blob/master/cmake/Z3Config.cmake.in

conan-center-bot · 2020-11-05T11:06:02Z

All green in build 4 (d489b31fce2ff6b6a901760d0182bed24cec089e)! 😊

cppcheck/2.2: Generated 68 packages. All logs here

conan-center-bot · 2020-11-05T11:56:58Z

Failure in build 5 (c41f8b8814f9110ed95ca11ec8c95712c86edddb):

cppcheck/2.2
- Hooks errors detected:
  - [HOOK - conan-center.py] pre_export(): ERROR: [NO FINAL ENDLINE (KB-H041)] File '/home/conan/w/cci_PR-3424/recipes/cppcheck/all/conandata.yml' does not end with an endline (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H041)

conan-center-bot · 2020-11-05T11:59:36Z

config.yml syntax error in build 6:

Only one library can be changed in the same PR: [cppcheck/all, flatc/all]|

This reverts commit 5fdcb4a.

conan-center-bot · 2020-11-05T12:13:33Z

Some configurations of 'cppcheck/2.2' failed in build 7 (3281eaf71d46f717248af7ce0572da1160005483):

Linux x86_64, Release, clang 3.9, libstdc++
Access to all the logs
Linux x86_64, Release, clang 6.0, libstdc++
Access to all the logs
Linux x86_64, Release, clang 7.0, libstdc++
Access to all the logs
Linux x86_64, Release, clang 5.0, libstdc++
Access to all the logs
Linux x86_64, Release, clang 5.0, libc++
Access to all the logs

conan-center-bot · 2020-11-05T14:07:43Z

Some configurations of 'cppcheck/2.2' failed in build 8 (08e3b56890923f0d2f40b4798cd20f301da7990c):

Linux x86_64, Release, gcc 4.9, libstdc++
Access to all the logs

conan-center-bot · 2020-11-05T14:27:45Z

Some configurations of 'cppcheck/2.2' failed in build 9 (c2a8cb9a6b71b24f84511fb3abdce2bdd1edb15c):

Linux x86_64, Release, clang 3.9, libc++
Access to all the logs
Linux x86_64, Release, clang 3.9, libstdc++
Access to all the logs
Linux x86_64, Release, clang 4.0, libc++
Access to all the logs
Linux x86_64, Release, clang 5.0, libstdc++
Access to all the logs
Windows x86_64, Debug, Visual Studio 14, MTd
Access to all the logs

conan-center-bot · 2020-11-06T08:44:19Z

Failure in build 10 (40fa9a02b1f0cb5121c6167679ccafbbc649e3f1):

Error processing recipe (ref 'cppcheck/2.2'): Linux x86_64, Release, gcc 4.9, libstdc++
You are depending on 'z3/4.8.8' but it is not in the repository

mjvankampen · 2020-11-06T09:24:46Z

I am unsure why the build fails, any tips?

prince-chrismc · 2020-11-06T23:54:02Z

$ conan search -r conan-center z3*   
Existing package recipes:

z3/4.8.8
$ conan search -r conan-center -rev z3/4.8.8@
Revisions for 'z3/4.8.8' at remote 'conan-center':
0d84ad48876496eb900c5ad9a028367e (2020-08-25 11:38:27 UTC)

Matches the original PR: #1451

😖

I can see a few minor changes, let's see if rebuilding will do the trick

recipes/cppcheck/all/CMakeLists.txt

prince-chrismc · 2020-11-06T23:55:34Z

recipes/cppcheck/all/CMakeLists.txt

+# Setup libraries to link
+set(Z3_LIBRARIES CONAN_PKG::z3)
+set(PCRE_LIBRARY CONAN_PKG::pcre)


What are these for? I dont see where they are being used 🤔

They are normally set in https://github.com/danmar/cppcheck/blob/488813d00fab8278a78d518cf0d3d6651c8f0caa/cmake/findDependencies.cmake and used in various places. Using the standard mechanism leaves out some other dependencies (in case of PCRE) or uses the wrong name (in case of z3).

Ahhh thank you for the insight, I did not get to that file while searching the repo! Awesome work!

prince-chrismc · 2020-11-07T00:00:45Z

recipes/cppcheck/all/conanfile.py

+        os.rename(extracted_dir, self._source_subfolder)
+
+    def _configure_cmake(self):
+        cmake = CMake(self)


Usually we ask to cache the CMake object, example: https://github.com/conan-io/conan-center-index/pull/3086/files#diff-ec045c054e4b94f8729715c3ec798f88b6dbda611dea1dd091597e2fa3d615bfR24

prince-chrismc · 2020-11-07T00:02:21Z

recipes/cppcheck/all/conanfile.py

+        cmake = CMake(self)
+        cmake.definitions["USE_Z3"] = self.options.with_z3
+        cmake.definitions["HAVE_RULES"] = self.options.have_rules
+        cmake.definitions["USE_MATCHCOMPILER"] = self.settings.build_type == "Release"


Looking at upstream, I am not 100% sure is this makes sense
https://github.com/danmar/cppcheck/blob/488813d00fab8278a78d518cf0d3d6651c8f0caa/cmake/options.cmake#L2

can you please confirm?

I changed the matchcompiler to "auto. The rest I left as is, I think those are correct.

That's exactly what I was looking at, just the github UI showing more.

recipes/cppcheck/all/conanfile.py

prince-chrismc · 2020-11-07T00:06:17Z

recipes/cppcheck/all/patches/0001-cmake-source-dir.patch

+             $<TARGET_OBJECTS:simplecpp_objs_sanitized>
+             $<TARGET_OBJECTS:tinyxml_objs_sanitized>
+             $<TARGET_OBJECTS:lib_objs_sanitized>)
+-    target_include_directories(fuzz-client PRIVATE ${CMAKE_SOURCE_DIR}/lib ${CMAKE_SOURCE_DIR}/externals/simplecpp ${CMAKE_SOURCE_DIR}/externals/tinyxml ${CMAKE_SOURCE_DIR}/externals)


I like to recommend keeping patches small. It appears that some of these are not relevant to building.

Would you mind trying to cut of the ones which are not a hard requirement?

Reduced it to dmake, thank you for all your comments!

Co-authored-by: Chris Mc <[email protected]>

conan-center-bot · 2020-11-08T12:47:56Z

All green in build 15 (0342f1deddb179a0a298ec5e2cf4ac6a87ad92c1)! 😊

cppcheck/2.2: Generated 68 packages. All logs here

prince-chrismc

🚀 LGTM !

ericLemanissier

disclaimer, I did not test this !

mjvankampen · 2020-11-10T07:44:01Z

recipes/cppcheck/all/CMakeLists.txt

+# Setup libraries to link
+set(Z3_LIBRARIES CONAN_PKG::z3)
+set(PCRE_LIBRARY CONAN_PKG::pcre)


Unfortunately this won't work. The z3 package is exposed as z3_LIBRARIES not Z3_LIBRARIES (ref. original Z3Config.cmake.in https://github.com/Z3Prover/z3/blob/master/cmake/Z3Config.cmake.in).

I could patch more files in cppcheck but I think it is nicer to solve it outside that project.

As for PCRE I think as cppcheck uses find_library dependencies of PCRE (such as mpir) are not linked in correct? I'm not 100% sure but I remember mpir linker errors. I will try.

Removing PCRE leads to errors as well.

cppcheck uses find_library to find pcre, so if you want this to work, you need to add the cmake_path generator to the recipe, and add include(conan_paths.cmake) to this CMakeLists.txt , as I suggested earlier
Regarding Z3, there is indeed an incompatibility in the varibales generated by conan. this is conan-io/conan#7691 striking again.

scratch that. this won't work as you pointed out, because find_library won't guess the dependencies. Too bad the upstream project uses cmake variables and find_library, instead of cmake targets :/

mjvankampen · 2020-11-10T07:44:01Z

recipes/cppcheck/all/CMakeLists.txt

+# Setup libraries to link
+set(Z3_LIBRARIES CONAN_PKG::z3)
+set(PCRE_LIBRARY CONAN_PKG::pcre)


Unfortunately this won't work. The z3 package is exposed as z3_LIBRARIES not Z3_LIBRARIES (ref. original Z3Config.cmake.in https://github.com/Z3Prover/z3/blob/master/cmake/Z3Config.cmake.in).

I could patch more files in cppcheck but I think it is nicer to solve it outside that project.

As for PCRE I think as cppcheck uses find_library dependencies of PCRE (such as mpir) are not linked in correct? I'm not 100% sure but I remember mpir linker errors. I will try.

conan-center-bot · 2020-11-10T08:02:26Z

Some configurations of 'cppcheck/2.2' failed in build 16 (259e3cf7cc6120c2d86e3f9d8d5bc807b7f588d7):

Windows x86_64, Debug, Visual Studio 14, MTd
Access to all the logs
Windows x86_64, Debug, Visual Studio 16, MTd
Access to all the logs

This reverts commit 259e3cf.

ericLemanissier · 2020-11-10T08:15:21Z

recipes/cppcheck/all/CMakeLists.txt

+# Setup libraries to link
+set(Z3_LIBRARIES CONAN_PKG::z3)
+set(PCRE_LIBRARY CONAN_PKG::pcre)


scratch that. this won't work as you pointed out, because find_library won't guess the dependencies. Too bad the upstream project uses cmake variables and find_library, instead of cmake targets :/

conan-center-bot · 2020-11-10T08:25:33Z

All green in build 17 (4fa00eb3a4329a74108246f10c8ea7bea099ae1c)! 😊

cppcheck/2.2: Generated 68 packages. All logs here

mjvankampen · 2020-11-10T08:27:55Z

Yeah that's a shame, when I find some time I will try to update cppcheck :)

Mark Jan van Kampen added 2 commits November 5, 2020 10:47

Adds cppcheck 2.2

ce2eb1f

Adds build_type

18cc73d

Adds Z3

f8fe968

It improves cppcheck reliability greatly

mjvankampen marked this pull request as draft November 5, 2020 10:19

conan-center-bot added the Failed label Nov 5, 2020

Mark Jan van Kampen added 2 commits November 5, 2020 11:43

Removes z3

768328e

The conan generated z3 package file does not provide the cmake definitions that cppcheck expects: https://github.com/Z3Prover/z3/blob/master/cmake/Z3Config.cmake.in

Removes require

d489b31

conan-center-bot removed the Failed label Nov 5, 2020

Adds patch to enable all features (z3 & pcre)

c41f8b8

conan-center-bot added the Failed label Nov 5, 2020

Adds missing newline

5fdcb4a

Mark Jan van Kampen added 2 commits November 5, 2020 13:01

Revert "Adds missing newline"

d181019

This reverts commit 5fdcb4a.

Adds newline

3281eaf

Adds cmake generator for MT flag

08e3b56

Simplifies configure

c2a8cb9

Removes a patch and cmake_find_package approach

40fa9a0

mjvankampen marked this pull request as ready for review November 6, 2020 09:23

prince-chrismc reviewed Nov 6, 2020

View reviewed changes

recipes/cppcheck/all/CMakeLists.txt Outdated Show resolved Hide resolved

prince-chrismc reviewed Nov 6, 2020

View reviewed changes

prince-chrismc reviewed Nov 7, 2020

View reviewed changes

recipes/cppcheck/all/conanfile.py Outdated Show resolved Hide resolved

prince-chrismc reviewed Nov 7, 2020

View reviewed changes

mjvankampen and others added 5 commits November 8, 2020 09:46

Removes superfluous message

c7a2c94

Co-authored-by: Chris Mc <[email protected]>

Removes unnecessary braces

bc39970

Co-authored-by: Chris Mc <[email protected]>

Disables OSS_FUZZ

7830933

Co-authored-by: Chris Mc <[email protected]>

Caches cmake and sets matchcompiler to auto

3309449

Reduces patch size

0342f1d

conan-center-bot removed the Failed label Nov 8, 2020

prince-chrismc previously approved these changes Nov 8, 2020

View reviewed changes

ericLemanissier reviewed Nov 9, 2020

View reviewed changes

mjvankampen commented Nov 10, 2020

View reviewed changes

Removes pcre lib

259e3cf

mjvankampen dismissed prince-chrismc’s stale review via 259e3cf November 10, 2020 07:48

conan-center-bot added the Failed label Nov 10, 2020

Revert "Removes pcre lib"

4fa00eb

This reverts commit 259e3cf.

ericLemanissier approved these changes Nov 10, 2020

View reviewed changes

conan-center-bot removed the Failed label Nov 10, 2020

prince-chrismc approved these changes Nov 10, 2020

View reviewed changes

SSE4 requested review from danimtb and uilianries November 11, 2020 18:57

qchateau mentioned this pull request Nov 16, 2020

Updatable recipes (dev) qchateau/conan-center-bot#4

Open

danimtb approved these changes Nov 16, 2020

View reviewed changes

conan-center-bot merged commit a1d9697 into conan-io:master Nov 16, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Cppcheck 2.2 #3424

Add Cppcheck 2.2 #3424

mjvankampen commented Nov 5, 2020 •

edited

Loading

conan-center-bot commented Nov 5, 2020

conan-center-bot commented Nov 5, 2020

conan-center-bot commented Nov 5, 2020

conan-center-bot commented Nov 5, 2020

conan-center-bot commented Nov 5, 2020

conan-center-bot commented Nov 5, 2020

conan-center-bot commented Nov 5, 2020

conan-center-bot commented Nov 5, 2020

conan-center-bot commented Nov 6, 2020

mjvankampen commented Nov 6, 2020

prince-chrismc commented Nov 6, 2020

prince-chrismc Nov 6, 2020

mjvankampen Nov 8, 2020

prince-chrismc Nov 8, 2020

prince-chrismc Nov 7, 2020

mjvankampen Nov 8, 2020

prince-chrismc Nov 7, 2020

mjvankampen Nov 8, 2020

prince-chrismc Nov 8, 2020

prince-chrismc Nov 7, 2020

mjvankampen Nov 8, 2020

conan-center-bot commented Nov 8, 2020

prince-chrismc left a comment

ericLemanissier left a comment

mjvankampen Nov 10, 2020 •

edited

Loading

mjvankampen Nov 10, 2020

ericLemanissier Nov 10, 2020

ericLemanissier Nov 10, 2020

mjvankampen Nov 10, 2020 •

edited

Loading

conan-center-bot commented Nov 10, 2020

ericLemanissier Nov 10, 2020

conan-center-bot commented Nov 10, 2020

mjvankampen commented Nov 10, 2020

Add Cppcheck 2.2 #3424

Add Cppcheck 2.2 #3424

Conversation

mjvankampen commented Nov 5, 2020 • edited Loading

conan-center-bot commented Nov 5, 2020

conan-center-bot commented Nov 5, 2020

conan-center-bot commented Nov 5, 2020

conan-center-bot commented Nov 5, 2020

conan-center-bot commented Nov 5, 2020

conan-center-bot commented Nov 5, 2020

conan-center-bot commented Nov 5, 2020

conan-center-bot commented Nov 5, 2020

conan-center-bot commented Nov 6, 2020

mjvankampen commented Nov 6, 2020

prince-chrismc commented Nov 6, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

conan-center-bot commented Nov 8, 2020

prince-chrismc left a comment

Choose a reason for hiding this comment

ericLemanissier left a comment

Choose a reason for hiding this comment

mjvankampen Nov 10, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mjvankampen Nov 10, 2020 • edited Loading

Choose a reason for hiding this comment

conan-center-bot commented Nov 10, 2020

Choose a reason for hiding this comment

conan-center-bot commented Nov 10, 2020

mjvankampen commented Nov 10, 2020

mjvankampen commented Nov 5, 2020 •

edited

Loading

mjvankampen Nov 10, 2020 •

edited

Loading

mjvankampen Nov 10, 2020 •

edited

Loading