Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pixman: patch in build() instead of source() + bump msys2 + del fPIC if shared + fix hooks #3225

Merged
merged 11 commits into from
Oct 20, 2020

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Oct 16, 2020

Specify library name and version: pixman/all

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

Also for consistency across recipes:

  • rename source subfolder after download/unarchive
  • delete cppstd and libcxx in configure() instead of config_options()

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Oct 16, 2020

@ericLemanissier I saw that test_package doesn't call pixman symbols if windows, do you know why? Would there be a way to have a minimal working test_package on windows?

@conan-center-bot
Copy link
Collaborator

All green in build 1 (8e8e8f4113de3ff9fe65e2c1f3b49affd38d1c5c)! 😊

@ericLemanissier
Copy link
Contributor

I don't know, but I just tested without the #ifdefs in debug and release, it passed. It's worth trying !

os.unlink(la)
self.copy(os.path.join(self._folder, 'COPYING'), dst='licenses')
tools.rmdir(os.path.join(self.package_folder, 'lib', 'pkgconfig'))
tools.rmdir(os.path.join(self.package_folder, 'lib', 'pkgconfig'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're at it, I think you forgot to convert these to double quotes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt it's needed, only adds additional noise

Co-authored-by: Anonymous Maarten <[email protected]>
@conan-center-bot
Copy link
Collaborator

Recipe syntax error in build 2:

WARN: Remotes registry file missing, creating default one in /home/conan/w/cci_PR-3225/2/78b37f72-f1ae-47e6-b1d4-913121c39260/.conan/remotes.json
ERROR: Error loading conanfile at '/home/conan/w/cci_PR-3225/recipes/pixman/all/conanfile.py': Unable to load conanfile in /home/conan/w/cci_PR-3225/recipes/pixman/all/conanfile.py
  File "/opt/pyenv/versions/3.7.5/lib/python3.7/site-packages/conans/model/ref.py", line 197, in loads
    name, version, user, channel, revision = get_reference_fields(text)
  File "/opt/pyenv/versions/3.7.5/lib/python3.7/site-packages/conans/model/ref.py", line 66, in get_reference_fields
    el1, el2 = _split_pair(arg_reference, "/") or (arg_reference, None)
  File "/opt/pyenv/versions/3.7.5/lib/python3.7/site-packages/conans/model/ref.py", line 18, in _split_pair
    raise ConanException("The reference has too many '{}'".format(split_char))
conans.errors.ConanException: The reference has too many '/'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/pyenv/versions/3.7.5/lib/python3.7/site-packages/conans/client/loader.py", line 361, in _parse_conanfile
    loaded = imp.load_source(module_id, conan_file_path)
  File "/opt/pyenv/versions/3.7.5/lib/python3.7/imp.py", line 171, in load_source
    module = _load(spec)
  File "<frozen importlib._bootstrap>", line 696, in _load
  File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 724, in exec_module
  File "<frozen importlib._bootstrap_external>", line 860, in get_code
  File "<frozen importlib._bootstrap_external>", line 791, in source_to_code
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/cci_PR-3225/recipes/pixman/all/conanfile.py", line 36
    raise ConanInvalidConfiguration("pixman can only be built as a static library on Windows")"
                                                                                              ^
SyntaxError: EOL while scanning string literal


@conan-center-bot
Copy link
Collaborator

All green in build 3 (1f61df10b452651c40aa61a4fce5eec786ede5cf)! 😊

prince-chrismc
prince-chrismc previously approved these changes Oct 18, 2020
@ericLemanissier
Copy link
Contributor

@SpaceIm you can merge this one in your PR if you want #3258

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Oct 19, 2020

@ericLemanissier done, thanks ;)

@conan-center-bot
Copy link
Collaborator

All green in build 4 (74090bf5d27cb0eefd730db7ea8a09c080677132)! 😊

@SSE4 SSE4 requested review from uilianries and danimtb October 19, 2020 15:52
@conan-center-bot conan-center-bot merged commit 5111573 into conan-io:master Oct 20, 2020
@SpaceIm SpaceIm deleted the fix/pixman-patch-source branch October 20, 2020 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants