-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pixman: patch in build() instead of source() + bump msys2 + del fPIC if shared + fix hooks #3225
pixman: patch in build() instead of source() + bump msys2 + del fPIC if shared + fix hooks #3225
Conversation
@ericLemanissier I saw that test_package doesn't call pixman symbols if windows, do you know why? Would there be a way to have a minimal working test_package on windows? |
All green in build 1 (
|
I don't know, but I just tested without the #ifdefs in debug and release, it passed. It's worth trying ! |
os.unlink(la) | ||
self.copy(os.path.join(self._folder, 'COPYING'), dst='licenses') | ||
tools.rmdir(os.path.join(self.package_folder, 'lib', 'pkgconfig')) | ||
tools.rmdir(os.path.join(self.package_folder, 'lib', 'pkgconfig')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you're at it, I think you forgot to convert these to double quotes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I doubt it's needed, only adds additional noise
Co-authored-by: Anonymous Maarten <[email protected]>
Recipe syntax error in build 2:
|
All green in build 3 (
|
@ericLemanissier done, thanks ;) |
All green in build 4 (
|
Specify library name and version: pixman/all
conan-center hook activated.
Also for consistency across recipes:
configure()
instead ofconfig_options()