-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Glib: Make libelf dependency optional #2925
Glib: Make libelf dependency optional #2925
Conversation
Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue. |
It looks good, let's wait for your EAP approval. Thank you for your contribution! |
Some configurations of 'glib/2.65.0' failed in build 3 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should either make your patch available to other versions of glib, or remove the with_elf
option if the version is < 2.66.0
recipes/glib/all/conandata.yml
Outdated
@@ -14,3 +14,7 @@ sources: | |||
"2.66.0": | |||
url: "https://download.gnome.org/sources/glib/2.66/glib-2.66.0.tar.xz" | |||
sha256: "c5a66bf143065648c135da4c943d2ac23cce15690fc91c358013b2889111156c" | |||
patches: | |||
"2.66.0": |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the patch available since 2.65.1 because it works from there. On 2.65.0 we keep the old behaviour.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should del self.options.with_libelf
in configure if self.version < tools.Version("2.65.1")
All other occurrences of self.options.with_elf
should be replaced with self.options.get_safe("with_elf", default=True)
Some configurations of 'glib/2.65.0' failed in build 4 (
|
But then packages that use glib 2.65.0 with |
libelf is always required if version < 2.65.1
@Erlkoenig90 Please consider Erlkoenig90#1 |
IMO it looks good, but that will break existing packages that use glib 2.65.0 with |
Oh yes correct, therefore we can delete this option in |
IIUC, with_elf option does not work without your patch, do I'd say a loud break is better than a silent break. |
It "half-works" as before, by enabling/disabling the conan dependency, and relying on meson to automatically find/not find the libelf dependency when building. |
I've updated Erlkoenig90#1 to delete |
Review glib optional elf
I detected other pull requests that are modifying glib/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
The patch is now part of glib >= 2.67.0 https://gitlab.gnome.org/GNOME/glib/-/commit/854abcd1afbf0f66cd568546dee5340502315705 If there is still interest in getting this patched for older versions, the PR needs to resolve the conflicts. |
…Lib version >= 2.67.0, remove patch as it is now upstream
…enter-index into glib-optional-libelf
Since the patch is upstream since 2.67.0, I simplified the PR to pass |
Co-authored-by: ericLemanissier <[email protected]>
All green in build 7 (
|
All green in build 8 (
|
Co-authored-by: Uilian Ries <[email protected]>
a57403f
All green in build 11 (
|
to retrigger ci... change the title or opening comment |
Specify library name and version: glib/2.66.0
This PR makes the glib dependency to libelf truly optional by patching the meson build files (upstream MR). This way, libelf is not used even if it's available in the system but
with_elf=False
is given.conan-center hook activated.