Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add opensslextra configure option #2167

Closed
wants to merge 2 commits into from
Closed

add opensslextra configure option #2167

wants to merge 2 commits into from

Conversation

kirandivekar
Copy link
Contributor

@kirandivekar kirandivekar commented Jul 9, 2020 •
edited by uilianries
Loading

Add support for opensslextra configuration option for openssl compatibility layer
default value is false.
This is based on the work from theirix PR 2027

closes #2154

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@kirandivekar
add opensslextra configure option
5a2bb3d 
Add support for opensslextra configuration option for openssl compatibility layer
default value is false.
This is based on the work from theirix PR 2027
@CLAassistant
Copy link

CLAassistant commented Jul 9, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@conan-center-bot
Copy link
Collaborator

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

This was referenced Jul 9, 2020
Closed
Open
uilianries
uilianries previously approved these changes Jul 9, 2020
View reviewed changes
@conan-center-bot
Copy link
Collaborator

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

@conan-center-bot
Copy link
Collaborator

An unexpected error happened and has been reported. Help is on its way! 🏇

@conan-center-bot
Copy link
Collaborator

Some configurations of 'wolfssl/4.4.0' failed in build 4 (5a2bb3da63a2524d0e54422342f8d1f465ed6b23):

@kirandivekar
Copy link
Contributor Author

I checked the failing CI logs. It shows

ERROR: Missing binary: automake/1.16.2:8f0570538ddd703bfc5400385a2fca9aa4a2b671
ERROR: Missing binary: libtool/2.4.6:1c19d2cb2281d70e5828ac1b9d3a4ed44671d717
automake/1.16.2: WARN: Can't find a 'automake/1.16.2' package for the specified settings, options and dependencies:
- Settings: os=Linux
- Options: 
- Dependencies: autoconf/2.69
- Requirements: autoconf/2.Y.Z
- Package ID: 8f0570538ddd703bfc5400385a2fca9aa4a2b671

ERROR: Missing prebuilt package for 'automake/1.16.2', 'libtool/2.4.6'
Try to build from sources with "--build=automake --build=libtool"
Or read "http://docs.conan.io/en/latest/faq/troubleshooting.html#error-missing-prebuilt-package"

Does the CI run with "--build=missing" flag?

@kirandivekar
Copy link
Contributor Author

Any suggestion how this CI error can be resolved? Does not look like related to my change.

@danimtb danimtb mentioned this pull request Jul 21, 2020
Closed
@danimtb
Copy link
Member

danimtb commented Jul 21, 2020

This was affected by #2196, I'll rerun the CI nos as it should be already fixed

@conan-center-bot
Copy link
Collaborator

Some configurations of 'wolfssl/4.4.0' failed in build 5 (5a2bb3da63a2524d0e54422342f8d1f465ed6b23):

@kirandivekar
Copy link
Contributor Author

I re-checked the CI logs. They are related to autoconf 2.69 package. Looks like same issue related to CI build in PR #2220 . which is a problem from issue #2196

@uilianries
Copy link
Member

Need to pass run_environment to self.run

@madebr
Copy link
Contributor

madebr commented Jul 22, 2020

Need to pass run_environment to self.run

This does not fix this problem.

Removing the dependency of autoconf on m4 fixes it for me.
So it looks like m4 and autoconf is still causing some problems on msys2.

@kirandivekar
Support for opensslall flag with opensslextra
b45618c 
With opensslextra only partial functionality gets enabled.
In order to enable complete functionality, using all OpenSSL
APIs, opensslall flag is needed. Added the same in the PR.
@conan-center-bot
Copy link
Collaborator

Some configurations of 'wolfssl/4.4.0' failed in build 6 (b45618cdf7b9f904ff96842eec9ba10a59a59202):

@kirandivekar
Copy link
Contributor Author

The CI logs again show a failure with autoconf. Looks like the same problem related to m4 dependancy.

@kirandivekar
Copy link
Contributor Author

Moving changes to new PR # 2276

@kirandivekar kirandivekar deleted the wolfssl-option-openssl-extra branch July 27, 2020 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries left review comments

Assignees

@uilianries uilianries

Labels
Failed Unexpected Error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[request] wolfssl/4.4.0 : support more configuration options like opensslextra
6 participants
@kirandivekar @CLAassistant @conan-center-bot @danimtb @uilianries @madebr