Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mfast recipe #2055

Merged
merged 11 commits into from
Jul 2, 2020
Merged

Add mfast recipe #2055

merged 11 commits into from
Jul 2, 2020

Conversation

tarc
Copy link
Contributor

@tarc tarc commented Jun 26, 2020 •
edited
Loading

Specify library name and version: mfast/1.2.1

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@tarc tarc marked this pull request as draft June 26, 2020 06:29
@conan-center-bot
Copy link
Collaborator

Some configurations of 'mfast/1.2.1' failed in build 1 (e5cbe0d25aa3077393acd986f991a39f52b94811):

@conan-center-bot
Copy link
Collaborator

Some configurations of 'mfast/1.2.1' failed in build 2 (b6e75618fdf5960e9c0c8d645e3e62b85156ef2f):

@conan-center-bot
Copy link
Collaborator

Some configurations of 'mfast/1.2.1' failed in build 3 (3180664705a1c454921acb093f21cf276d94f017):

uilianries
uilianries requested changes Jun 26, 2020
View reviewed changes
recipes/mfast/all/conanfile.py Outdated Show resolved Hide resolved
recipes/mfast/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot
Copy link
Collaborator

An unexpected error happened and has been reported. Help is on its way! 🏇

@conan-center-bot
Copy link
Collaborator

Some configurations of 'mfast/1.2.1' failed in build 6 (cd4870bcf943a9da78eb9a18e0cb0897120aa38a):

@conan-center-bot
Copy link
Collaborator

Some configurations of 'mfast/1.2.1' failed in build 7 (5e5b0d330ccf7eb500c3ce328c346eeabfab1027):

@conan-center-bot
Copy link
Collaborator

All green in build 8 (a7c6d214b166c668973184791e182b5d3f11a77d)! 😊

@tarc tarc marked this pull request as ready for review June 26, 2020 23:28
@conan-center-bot
Copy link
Collaborator

An unexpected error happened and has been reported. Help is on its way! 🏇

@conan-center-bot
Copy link
Collaborator

An unexpected error happened and has been reported. Help is on its way! 🏇

@conan-center-bot
Copy link
Collaborator

All green in build 11 (e9a78ae574f652151f4aa29f4bd232a0e4acbafa)! 😊

uilianries
uilianries requested changes Jun 29, 2020
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, please, take a look on my comments.

recipes/mfast/all/conanfile.py Show resolved Hide resolved
recipes/mfast/all/patches/00005-add-conan-libs-to-targets.patch.txt Show resolved Hide resolved
recipes/mfast/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved
recipes/mfast/all/test_package/conanfile.py Outdated Show resolved Hide resolved
recipes/mfast/all/test_package/message_printer.h Outdated Show resolved Hide resolved
recipes/mfast/all/conanfile.py Show resolved Hide resolved
@tarc @uilianries
Apply suggestions from code review
d928f64 
Remove boost require from test package and fPIC option from shared builds.

Co-authored-by: Uilian Ries <[email protected]>
@conan-center-bot
Copy link
Collaborator

All green in build 12 (d928f64925de82c08c099dd4f4c57e2b32a1406b)! 😊

@conan-center-bot
Copy link
Collaborator

Some configurations of 'mfast/1.2.1' failed in build 13 (ede34d74f060118b2048e9774e339b7a15910e7e):

@conan-center-bot
Copy link
Collaborator

All green in build 14 (73824e3d185b161dac7e5a908c4a5c200eeef911)! 😊

@conan-center-bot
Copy link
Collaborator

All green in build 15 (96928b18799e5951717fc58b4ce788b0bf6d8372)! 😊

@SSE4 SSE4 requested a review from danimtb July 2, 2020 05:37
uilianries
uilianries approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uilianries uilianries requested a review from SSE4 July 2, 2020 13:57
@SSE4 SSE4 merged commit c71de2c into conan-io:master Jul 2, 2020
@tarc tarc deleted the feature/mFAST branch July 2, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danimtb danimtb danimtb approved these changes

@uilianries uilianries uilianries approved these changes

@SSE4 SSE4 SSE4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tarc @conan-center-bot @SSE4 @uilianries @danimtb