-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resiprocate: add 1.13.1 #20465
resiprocate: add 1.13.1 #20465
Conversation
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 3ac4188resiprocate/cci.20231009@#952a535dce762bda224172873ab6cedb
|
Thanks for the extra info in the link @gjasny, those are super appreciated :) |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 2eccddaresiprocate/cci.20231009@#4ad9f23ff0ba252088005c1209319a79
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 44372bbresiprocate/cci.20231127@#6350d978cdf43f644158b09920793438
|
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 13 (
Conan v2 pipeline ✔️
All green in build 13 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Updating the snapshot version before this gets merged would not hurt.
2bf534d
to
00c9e36
Compare
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
00c9e36
to
3e1590e
Compare
Co-authored-by: Martin Valgur <[email protected]> Co-authored-by: PerseoGI <[email protected]>
3e1590e
to
621f49b
Compare
Hi @gjasny
I'm so sorry for the terribly long time in reviewing this PR 😭 I'll prioritize this PR into my list to be reviewed ASAP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this PR @gjasny
LGTM! 👏 I only have a question before approving. I think that VirtualBuildEnv
is useless here, but, maybe, I'm missing anything else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👏
Thanks @gjasny
|
||
def package_info(self): | ||
resiprocate_lib = "resiprocate" if self.settings.os == "Windows" else "resip" | ||
self.cpp_info.libs = [resiprocate_lib, "rutil", "dum"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AbrilRBS is working on this to split these libraries into several components. She'll update the PR soon
def validate(self): | ||
check_min_cppstd(self, 11) | ||
if is_msvc(self) and self.options.shared: | ||
raise ConanInvalidConfiguration(f"{self.ref} can not be built as shared on msvc, it does not export required symbols.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specify library name and version: resiprocate/1.13.1
Since the 1 and a half years that this PR is open (😢) a new stable release happened. The PR has been updated accordingly.