Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resiprocate: add 1.13.1 #20465

Merged
merged 7 commits into from
Feb 3, 2025
Merged

resiprocate: add 1.13.1 #20465

merged 7 commits into from
Feb 3, 2025

Conversation

gjasny
Copy link
Contributor

@gjasny gjasny commented Oct 9, 2023

Specify library name and version: resiprocate/1.13.1

Since the 1 and a half years that this PR is open (😢) a new stable release happened. The PR has been updated accordingly.


@gjasny gjasny marked this pull request as draft October 9, 2023 14:04
@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Hooks produced the following warnings for commit 3ac4188
resiprocate/cci.20231009@#952a535dce762bda224172873ab6cedb
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libresip-1.13.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libsipdial.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/librutil-1.13.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdum-1.13.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libsipdial-1.13.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdum.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/librutil.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libresip.so' links to system library 'm' but it is not in cpp_info.system_libs.

@AbrilRBS AbrilRBS self-assigned this Oct 9, 2023
@AbrilRBS
Copy link
Member

AbrilRBS commented Oct 9, 2023

Thanks for the extra info in the link @gjasny, those are super appreciated :)

@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Hooks produced the following warnings for commit 2eccdda
resiprocate/cci.20231009@#4ad9f23ff0ba252088005c1209319a79
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libsipdial.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdum.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/librutil.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libresip.so' links to system library 'm' but it is not in cpp_info.system_libs.

@conan-center-bot

This comment has been minimized.

recipes/resiprocate/cmake/conanfile.py Outdated Show resolved Hide resolved
recipes/resiprocate/cmake/conanfile.py Show resolved Hide resolved
recipes/resiprocate/cmake/conanfile.py Outdated Show resolved Hide resolved
recipes/resiprocate/cmake/conandata.yml Outdated Show resolved Hide resolved
recipes/resiprocate/config.yml Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit 44372bb
resiprocate/cci.20231127@#6350d978cdf43f644158b09920793438
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdum.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libresip.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libsipdial.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdum.dylib' links to system library 'Security' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libresip.dylib' links to system library 'Security' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libsipdial.dylib' links to system library 'Security' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdum.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libresip.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libsipdial.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 13 (088c913705d31642a92bf5fea88f15dfc7769c5a):

  • resiprocate/cci.20231127:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 13 (088c913705d31642a92bf5fea88f15dfc7769c5a):

  • resiprocate/cci.20231127:
    All packages built successfully! (All logs)

Copy link
Contributor

@valgur valgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Updating the snapshot version before this gets merged would not hurt.

@jcar87 jcar87 self-assigned this Nov 12, 2024
@AbrilRBS AbrilRBS removed their assignment Dec 3, 2024
@gjasny gjasny force-pushed the resiprocate/add-head branch from 2bf534d to 00c9e36 Compare December 20, 2024 10:02
@gjasny gjasny changed the title resiprocate: add master snapshot resiprocate: add 1.13.0-beta1 Dec 20, 2024
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 20, 2025
@jcar87
Copy link
Contributor

jcar87 commented Jan 20, 2025

cc @franramirez688

@gjasny gjasny force-pushed the resiprocate/add-head branch from 00c9e36 to 3e1590e Compare January 20, 2025 18:26
@gjasny gjasny changed the title resiprocate: add 1.13.0-beta1 resiprocate: add 1.13.1 Jan 20, 2025
Co-authored-by: Martin Valgur <[email protected]>
Co-authored-by: PerseoGI <[email protected]>
@gjasny gjasny force-pushed the resiprocate/add-head branch from 3e1590e to 621f49b Compare January 20, 2025 18:37
@github-actions github-actions bot removed the stale label Jan 21, 2025
@franramirez688
Copy link
Contributor

Hi @gjasny

Since the 1 and a half years that this PR is open (😢) a new stable release happened. The PR has been updated accordingly.

I'm so sorry for the terribly long time in reviewing this PR 😭 I'll prioritize this PR into my list to be reviewed ASAP.
Thank you so much for the effort of opening this PR and keeping it up-to-date till the end 👏

Copy link
Contributor

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR @gjasny

LGTM! 👏 I only have a question before approving. I think that VirtualBuildEnv is useless here, but, maybe, I'm missing anything else.

recipes/resiprocate/cmake/conanfile.py Outdated Show resolved Hide resolved
recipes/resiprocate/cmake/conanfile.py Outdated Show resolved Hide resolved
franramirez688
franramirez688 previously approved these changes Jan 28, 2025
Copy link
Contributor

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👏

Thanks @gjasny


def package_info(self):
resiprocate_lib = "resiprocate" if self.settings.os == "Windows" else "resip"
self.cpp_info.libs = [resiprocate_lib, "rutil", "dum"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AbrilRBS is working on this to split these libraries into several components. She'll update the PR soon

def validate(self):
check_min_cppstd(self, 11)
if is_msvc(self) and self.options.shared:
raise ConanInvalidConfiguration(f"{self.ref} can not be built as shared on msvc, it does not export required symbols.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AbrilRBS and I were trying to compile it as shared and we saw those export symbol errors, that's why we updated the message. @gjasny Is this the real problem? Are there any open issues related to this?

AbrilRBS
AbrilRBS previously approved these changes Jan 28, 2025
franramirez688
franramirez688 previously approved these changes Jan 28, 2025
@jcar87 jcar87 dismissed stale reviews from franramirez688 and AbrilRBS via 4b5d0b6 February 3, 2025 12:04
@jcar87 jcar87 merged commit 9c38198 into conan-io:master Feb 3, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants