-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
automake: add include directories from environment variable #2038
Conversation
…viding m4 scripts
All green in build 1 (
|
All green in build 2 (
|
@danimtb @uilianries @SSE4 @jgsogo |
@@ -49,7 +50,9 @@ def _build_scripts(self): | |||
|
|||
def _build_autotools(self): | |||
"""Test autoreconf + configure + make""" | |||
self.run("{} --verbose --install".format(os.environ["AUTORECONF"]), win_bash=tools.os_info.is_windows) | |||
with tools.environment_append({"AUTOMAKE_CONAN_INCLUDES": [tools.unix_path(self.source_folder)]}): | |||
print(os.environ["AUTOMAKE_CONAN_INCLUDES"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use self.output.info
if this is something you want to print in the build process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a remainder of a debug session. It can be removed.
@@ -107,5 +107,7 @@ def package_info(self): | |||
self.output.info("Setting AUTOMAKE to {}".format(automake)) | |||
self.env_info.AUTOMAKE = automake | |||
|
|||
self.output.info("Append M4 include directories to AUTOMAKE_CONAN_INCLUDES environment variable") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something the consumers need to add themselves? Why not populating here that environment variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, consumers need to populate this.
pkgconf is an example:
A default autoconf/automake installation provides a few standard macros to generate the configure
script.
pkgconf provides a m4
file which extends this list of macros with pkg-config related macros (see pkgconf's test_package for an example).
Please also check out the zbar pull request. There we found out that the default autoconf/automake misses macros related to iconv to which I don't have a good solution yet.
This would also be a good use case of your context concept. It would be nice to require a dependency, but only in the context of running autoreconf
.
All green in build 3 (
|
Specify library name and version: automake/**
When running
autoreconf
, a project'sconfigure.ac
might need axxx.m4
file,provided by another package.
This pr lets automake use the
AUTOMAKE_CONAN_INCLUDES
environment variable.By appending paths to this variable, automake will look for
.m4
scripts.This is part of a solution for reconfiguring zbar.
See #2029
conan-center hook activated.