Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meson 0.54.3 #2034

Merged
merged 2 commits into from
Jun 26, 2020
Merged

Meson 0.54.3 #2034

merged 2 commits into from
Jun 26, 2020

Conversation

ericLemanissier
Copy link
Contributor

Specify library name and version: meson/0.54.3

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

All green in build 1 (9b79021c4c5ff3c70536458b255ed6fcb96b7667)! 😊

@madebr
Copy link
Contributor

madebr commented Jun 24, 2020

@ericLemanissier
I'm seeing the following error when using meson:
#2000 (comment)

Meson contains a cmake script to which KB-H019 complains: ./bin/mesonbuild/cmake/data/preload.cmake

/cc @uilianries

@SSE4 SSE4 requested review from danimtb and uilianries June 25, 2020 04:45
@ericLemanissier
Copy link
Contributor Author

ericLemanissier commented Jun 25, 2020

this hook message happens with all projects consuming meson, in all configurations. The strange part is that the bot reports it only for gcc4.9 configuration, and if you look at the log, you realize that the failure happens actually later, and is the usual ninja: relocation error: ninja: symbol _ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEE7reserveEm, version GLIBCXX_3.4.21 not defined in file libstdc++.so.6 with link time reference, so it is actually #213

So there are several issues colliding :

  1. as @madebr, I think we should add an exception to the hook to allow this file in meson package.
  2. the bot should be checked to understand why this hook message is only reported in case of build failure
  3. [service] Installer packages can't be used in older enviroments  #213. In the case of ninja, it could be solved by modifying the recipe to simply download upstream binaries: https://github.com/ninja-build/ninja/releases

@uilianries uilianries merged commit 5c3c261 into conan-io:master Jun 26, 2020
@uilianries uilianries deleted the meson branch June 26, 2020 18:23
@madebr
Copy link
Contributor

madebr commented Jul 3, 2020

@ericLemanissier
I'm seeing this error/warning at the end of ninja install (log here)

Error in atexit._run_exitfuncs:


Traceback (most recent call last):


  File "C:\Python36\lib\site-packages\colorama\ansitowin32.py", line 59, in closed


    return stream.closed


ValueError: underlying buffer has been detached

Would it make sense to build/install meson for all operating systems (add os to settings)
in order to test meson/ninja on all operating systems when creating the meson package?

I'm doing something similar with autoconf/automake.
Even though these are script-only package, they are available for each operating system as a dedicated package.

Or does the problem lie with conan?

@ericLemanissier
Copy link
Contributor Author

regarding pkgconf, I don't have this error on my computer:

pkgconf/1.7.3 (test package): Running test()
error callback: C:\pf\conan-center-index\recipes\pkgconf\all\test_package\test_package.c:19 main: test error
-L/usr/lib -lexample1
-I/usr/include/libexample1 -I/usr/include -DEXAMPLE1_STATIC

regarding meson, making a PR adding os to settings should be enough to see if it works ok in CCI's jenkins environment.

@madebr
Copy link
Contributor

madebr commented Jul 3, 2020

@ericLemanissier
I manually create that error message.
It's normal to have one.
So not seeing it, is an error.

@ericLemanissier
Copy link
Contributor Author

ericLemanissier commented Jul 3, 2020

regarding pkgconf: Yes, I was just trying to show that it did not fail on my machine ;)
regardring meson: #2119

@ericLemanissier ericLemanissier mentioned this pull request Jul 3, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants