Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libtommath: migrate to Conan v2 #18852

Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open

libtommath: migrate to Conan v2 #18852

wants to merge 36 commits into from

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 23, 2023 •
edited
Loading

Continues from #16558 with minimal changes (also resolves #16558).

@ghost ghost mentioned this pull request Jul 23, 2023
Closed
@prince-chrismc prince-chrismc mentioned this pull request Jul 23, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur closed this Jul 26, 2023
@valgur valgur reopened this Aug 11, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@stale
Copy link

stale bot commented Sep 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added stale and removed stale labels Sep 17, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur force-pushed the migrate/libtommath branch from c9d4fa1 to 2305207 Compare November 2, 2023 05:33
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur mentioned this pull request Nov 8, 2023
Open
@valgur valgur force-pushed the migrate/libtommath branch from 2305207 to 7f1cf27 Compare November 27, 2023 15:40
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
This was referenced Jan 2, 2024
Draft
Closed
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 6 (1828fa1b8f579140ea452a8970e171544c657a81):

  • libtommath/1.2.1:
    All packages built successfully! (All logs)

  • libtommath/1.3.0:
    All packages built successfully! (All logs)

  • libtommath/1.2.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 6 (1828fa1b8f579140ea452a8970e171544c657a81):

  • libtommath/1.3.0:
    All packages built successfully! (All logs)

  • libtommath/1.2.1:
    All packages built successfully! (All logs)

  • libtommath/1.2.0:
    All packages built successfully! (All logs)

@valgur valgur requested a review from AbrilRBS September 3, 2024 21:29
@uilianries uilianries self-assigned this Sep 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 24, 2024
@valgur
Copy link
Contributor Author

valgur commented Oct 24, 2024

.

@github-actions github-actions bot removed the stale label Oct 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 24, 2024
@valgur
Copy link
Contributor Author

valgur commented Nov 24, 2024

.

@github-actions github-actions bot removed the stale label Nov 25, 2024
@AbrilRBS AbrilRBS removed their assignment Dec 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 26, 2024
@valgur
Copy link
Contributor Author

valgur commented Dec 26, 2024

.

@github-actions github-actions bot removed the stale label Dec 27, 2024
@uilianries
Stop maintaining versions <1.3
Loading
Loading status checks…
1987295 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Avoid checking <1.3 version in the recipe
723197f 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Do not support shared library on Windows
304e541 
The project is capable to export symbols to generate a .dll

Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Skip removing .pdb files. They are not generated"
75b9474 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Requires Conan 2.x
d8b1652 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Simplify test package
99da2cc 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Skip debug build
b707800 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Merge branch 'master' of https://github.com/conan-io/conan-center-index…
421b8fb 
… into migrate/libtommath
uilianries
uilianries previously approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valgur Thank you for continuing this PR.

I did a few changes on this PR, in order to simplify it:

  • The version 1.3.0 includes CMakeLists.txt in its root folder. Supporting only this version simplifies the recipes a lot too.
  • The upstream can not export symbols on Windows to generate a .dll. So I dropped shared library as well on Windows
  • Simplified the test package to only validate the library.
  • Dropped Windows debug support for now. First, CCI don't build package on Debug due the lower number the downloads and other topics, so we can not validate. Second, the upstream recommends inject /O1 instead of the default Cmake configuration /Og. In case an user really need Debug build type, then an issue can be opened to discuss this topic, but would need to pass CMAKE_C_FLAGS_DEBUG or similar.

@uilianries uilianries dismissed their stale review January 30, 2025 07:47

Doing extra review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwillikers jwillikers

@uilianries uilianries

@AbrilRBS AbrilRBS

At least 1 approving review is required to merge this pull request.

Assignees

@uilianries uilianries

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@valgur @conan-center-bot @uilianries @AbrilRBS @jwillikers @jowr @prince-chrismc