Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

access_private: add package_type #18167

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jun 30, 2023

No description provided.

@conan-center-bot

This comment has been minimized.

@AbrilRBS
Copy link
Member

AbrilRBS commented Jul 1, 2023

@valgur thanks a lot for your contributions, but this seems to have an issue: We're not currently allowing the removal of test_v1_packages to recipes that already have them, only to new ones.
I see that you have open lots of PRs (It's going to take us a while to process all of them, give us some time!) and by quickly glancing at some of them, they also have those files removed, which is going to be a blocker for most of them, even the rest of the changes look good :/

We can revert the deletions manually, but maybe doing it on your end is better? Just keep in mind not to trigger the changes all at once so the CI systems are able to cope with the rest of the normal traffic :)

@valgur
Copy link
Contributor Author

valgur commented Jul 2, 2023

@RubenRBS
Oh, my bad. Sorry about that. I will fix this in batch on my end asap. I'll take care to not overload the CI.

Also, regarding the PRs - I won't mind in the least if you drop them onto the bottom of the review queue. I will be away for the next two weeks and won't be able work on any change requests in the PRs for that duration anyway.

@valgur valgur mentioned this pull request Jul 4, 2023
3 tasks
@valgur valgur reopened this Jul 4, 2023
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (151c6eb10051202001a052e0d60f2db6f64cead5):

  • access_private/cci.20210621@:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 2 (151c6eb10051202001a052e0d60f2db6f64cead5):

  • access_private/cci.20210621@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 18b58bb into conan-io:master Jul 5, 2023
pezy pushed a commit to pezy/conan-center-index that referenced this pull request Jul 15, 2023
* access_private: add package_type

* access_private: restore test_v1_package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants