Add nlohmann_json 3.4.0 for better compatibility #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conan-center-bot
added
the
Bump version
|
All green in build 1 (
|
SSE4
previously approved these changes
Jun 1, 2020
danimtb
previously approved these changes
Jun 1, 2020
uilianries
approved these changes
Jun 1, 2020
SSE4
approved these changes
Jun 1, 2020
syoliver
approved these changes
Jun 2, 2020
danimtb
approved these changes
Jun 2, 2020
|
All green in build 2 (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: nlohmann_json/3.4.0
There are some compatibility issues when I update nlohmann 3.7.x. My team have use jsonformoderncpp/3.4.0@vthiery/stable for nearly two year with no problem. I think this version may has better compatibility.
Here are issues that I had:
error when using nlohmann::json, std::function and std::bind nlohmann/json#2147
/Zc:__cplusplus leads to C2416 nlohmann/json#1695
I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.