Package/nodejs v18 #16964

KozhinovAlexander · 2023-04-10T19:24:11Z

add nodejs v18

It is a follow-up to #16966

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

ghost · 2023-04-10T19:35:53Z

I detected other pull requests that are modifying nodejs/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

KozhinovAlexander · 2023-04-11T01:23:51Z

Conan v1 pipeline ❌

Changes not allowed in build 8:
[libudev, nodejs]
Only one library can be changed in the same PR.

Conan v2 pipeline (informative, not required for merge) ❌

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.
See details:

Changes not allowed in build 8:
[libudev, nodejs]
Only one library can be changed in the same PR.

The rule here is totally unnecessary and makes people avoid doing PR.

KozhinovAlexander · 2023-05-02T12:16:10Z

This one is the followup to #16966
@gjasny @prince-chrismc @SSE4 please review

KozhinovAlexander · 2023-05-02T12:16:57Z

@franramirez688 @uilianries please review

gjasny · 2023-05-02T12:42:18Z

Could you please merge in master so that the diff-noise is reduced to the actual changes.

gjasny · 2023-05-02T12:53:41Z

recipes/nodejs/config.yml

@@ -5,3 +5,5 @@ versions:
    folder: all
  "16.3.0":
    folder: all
+  "18.15.0":


Would it make sense to package 18.16.0 to reduce the amount of versions in cci?

Would it make sense to package 18.16.0 to reduce the amount of versions in cci?

Seems to be newer one. Sure. I'll do. It needs me a bit more time, since I am Not able currently edit or from my pc.

KozhinovAlexander · 2023-05-02T13:42:19Z

Could you please merge in master so that the diff-noise is reduced to the actual changes.

Done

KozhinovAlexander · 2023-05-02T13:47:38Z

@SSE4 I merged master into this branch. Please Approved again. Sorry for the noice.

prince-chrismc · 2023-05-02T17:50:53Z

nvm this was a different PR I o got confused

KozhinovAlexander · 2023-05-02T20:48:47Z

@gjasny For sake of siplicity I will keep v18.15.0 and prefer to add new one in a separate PR.

conan-center-bot · 2023-05-05T18:16:12Z

Conan v1 pipeline ✔️

All green in build 35 (953942fc5649dcb08dca61d6a0500131cf886e3f):

nodejs/18.15.0@:
All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 34 (953942fc5649dcb08dca61d6a0500131cf886e3f):

nodejs/18.15.0@:
All packages built successfully! (All logs)

* nodejs: conanfile.py: prepare for v18 Signed-off-by: Alexander Kozhinov <[email protected]> * test_package: conanfile.py: update for conan v2 usage Signed-off-by: Alexander Kozhinov <[email protected]> * Update recipes/nodejs/all/conanfile.py Co-authored-by: Chris Mc <[email protected]> * nodejs: conanfile.py: remove compiler verification Signed-off-by: Alexander Kozhinov <[email protected]> * nodejs: test_package: rework for v1 and v2 Signed-off-by: Alexander Kozhinov <[email protected]> * Update recipes/nodejs/all/conanfile.py Co-authored-by: Chris Mc <[email protected]> * nodejse: conanfile.py: rework conan_version test Signed-off-by: Alexander Kozhinov <[email protected]> * Update recipes/nodejs/all/conanfile.py Co-authored-by: Gregor Jasny <[email protected]> * Update recipes/nodejs/all/test_package/conanfile.py Co-authored-by: Gregor Jasny <[email protected]> * Update recipes/nodejs/all/conanfile.py Co-authored-by: Gregor Jasny <[email protected]> * Update recipes/nodejs/all/conanfile.py Co-authored-by: Gregor Jasny <[email protected]> * nodejs: conanfile.py: use self.settings instead of self.info.settings Signed-off-by: Alexander Kozhinov <[email protected]> * nodejs: conanfile.py: do not use self.settings in source() method Signed-off-by: Alexander Kozhinov <[email protected]> * nodejs: conanfile.py: use subprocess in _glibc_version Signed-off-by: Alexander Kozhinov <[email protected]> * Update recipes/nodejs/all/conanfile.py Co-authored-by: Chris Mc <[email protected]> * Update recipes/nodejs/all/conanfile.py Co-authored-by: Chris Mc <[email protected]> * Update recipes/nodejs/all/conanfile.py Co-authored-by: Chris Mc <[email protected]> * Update recipes/nodejs/all/conanfile.py Co-authored-by: Chris Mc <[email protected]> * nodejs: conanfile.py: fix arch / revert _glibc_version Signed-off-by: Alexander Kozhinov <[email protected]> * nodejs: conanfile.py: remove dobule defined build() method Signed-off-by: Alexander Kozhinov <[email protected]> * nodejs: conanfile.py: fix glibc version aquisition Signed-off-by: Alexander Kozhinov <[email protected]> * nodejs: add v18 Signed-off-by: Alexander Kozhinov <[email protected]> * Update config.yml * Update config.yml --------- Signed-off-by: Alexander Kozhinov <[email protected]> Co-authored-by: Chris Mc <[email protected]> Co-authored-by: Gregor Jasny <[email protected]>

ghost mentioned this pull request Apr 10, 2023

[service] Potentially conflicting recipes #3571

Closed

ghost mentioned this pull request Apr 10, 2023

feat(nodejs): make recipe Conan 2.0 ready #16908

Closed

3 tasks

conan-center-bot added the Failed label Apr 10, 2023

This comment has been minimized.

Sign in to view

KozhinovAlexander force-pushed the package/nodejs_v18 branch from 66984ba to 3ad559d Compare April 10, 2023 19:59

This comment has been minimized.

Sign in to view

KozhinovAlexander force-pushed the package/nodejs_v18 branch 2 times, most recently from 2924b07 to eeb45e3 Compare April 10, 2023 20:44

This comment has been minimized.

Sign in to view

KozhinovAlexander force-pushed the package/nodejs_v18 branch 3 times, most recently from eee65c9 to 0301e33 Compare April 10, 2023 21:45

This comment has been minimized.

Sign in to view

KozhinovAlexander force-pushed the package/nodejs_v18 branch from 0301e33 to 1c7a171 Compare April 10, 2023 22:46

This comment has been minimized.

Sign in to view

KozhinovAlexander force-pushed the package/nodejs_v18 branch 2 times, most recently from cd798aa to 81ee2f4 Compare April 11, 2023 07:21

ghost mentioned this pull request Apr 11, 2023

Prepare nodejs for v18 #16966

Merged

3 tasks

This comment has been minimized.

Sign in to view

KozhinovAlexander force-pushed the package/nodejs_v18 branch from 81ee2f4 to 1407c8d Compare April 11, 2023 09:51

This comment has been minimized.

Sign in to view

KozhinovAlexander force-pushed the package/nodejs_v18 branch 2 times, most recently from 2dd9c2b to 960708c Compare April 11, 2023 10:19

This comment has been minimized.

Sign in to view

KozhinovAlexander force-pushed the package/nodejs_v18 branch from 960708c to fe5df7d Compare April 11, 2023 11:56

conan-center-bot removed the Failed label Apr 11, 2023

This comment has been minimized.

Sign in to view

KozhinovAlexander force-pushed the package/nodejs_v18 branch from fe5df7d to 3e9b5ba Compare April 11, 2023 13:17

This comment has been minimized.

Sign in to view

SSE4 previously approved these changes May 2, 2023

View reviewed changes

gjasny reviewed May 2, 2023

View reviewed changes

Merge branch 'master' into package/nodejs_v18

0a75468

Update config.yml

ceea93f

KozhinovAlexander dismissed SSE4’s stale review via ceea93f May 2, 2023 13:43

Update config.yml

f512e92

gjasny approved these changes May 2, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

prince-chrismc approved these changes May 2, 2023

View reviewed changes

KozhinovAlexander requested review from gjasny and SSE4 May 2, 2023 20:47

gjasny approved these changes May 3, 2023

View reviewed changes

Merge branch 'master' into package/nodejs_v18

156a2be

conan-center-bot added the Unexpected Error label May 5, 2023

This comment has been minimized.

Sign in to view

jwillikers approved these changes May 5, 2023

View reviewed changes

Merge branch 'master' into package/nodejs_v18

953942f

conan-center-bot removed the Unexpected Error label May 5, 2023

conan-center-bot merged commit 77d75d3 into conan-io:master May 5, 2023

KozhinovAlexander deleted the package/nodejs_v18 branch May 5, 2023 19:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Package/nodejs v18 #16964

Package/nodejs v18 #16964

KozhinovAlexander commented Apr 10, 2023 •

edited

Loading

ghost commented Apr 10, 2023 •

edited by ghost

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

KozhinovAlexander commented Apr 11, 2023 •

edited

Loading

Conan v1 pipeline ❌

Conan v2 pipeline (informative, not required for merge) ❌

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

KozhinovAlexander commented May 2, 2023

KozhinovAlexander commented May 2, 2023

gjasny commented May 2, 2023

gjasny May 2, 2023

KozhinovAlexander May 2, 2023 •

edited

Loading

KozhinovAlexander commented May 2, 2023

KozhinovAlexander commented May 2, 2023

This comment has been minimized.

prince-chrismc commented May 2, 2023 •

edited

Loading

KozhinovAlexander commented May 2, 2023

This comment has been minimized.

conan-center-bot commented May 5, 2023

Package/nodejs v18 #16964

Package/nodejs v18 #16964

Conversation

KozhinovAlexander commented Apr 10, 2023 • edited Loading

ghost commented Apr 10, 2023 • edited by ghost Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

KozhinovAlexander commented Apr 11, 2023 • edited Loading

Conan v1 pipeline ❌

Conan v2 pipeline (informative, not required for merge) ❌

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

KozhinovAlexander commented May 2, 2023

KozhinovAlexander commented May 2, 2023

gjasny commented May 2, 2023

gjasny May 2, 2023

Choose a reason for hiding this comment

KozhinovAlexander May 2, 2023 • edited Loading

Choose a reason for hiding this comment

KozhinovAlexander commented May 2, 2023

KozhinovAlexander commented May 2, 2023

This comment has been minimized.

prince-chrismc commented May 2, 2023 • edited Loading

KozhinovAlexander commented May 2, 2023

This comment has been minimized.

conan-center-bot commented May 5, 2023

Conan v1 pipeline ✔️

Conan v2 pipeline ✔️

KozhinovAlexander commented Apr 10, 2023 •

edited

Loading

ghost commented Apr 10, 2023 •

edited by ghost

Loading

KozhinovAlexander commented Apr 11, 2023 •

edited

Loading

KozhinovAlexander May 2, 2023 •

edited

Loading

prince-chrismc commented May 2, 2023 •

edited

Loading