zlib: fix MinGW clang #14644
zlib: fix MinGW clang #14644
Conversation
SpaceIm
force-pushed
the
zlib-improve-is-mingw
branch
from
82362e9 to
da0729b
Compare
| host_os = self.settings.os | ||
| host_compiler = self.settings.get_safe("compiler") | ||
| mingw_gcc = host_os == "Windows" and host_compiler == "gcc" | ||
| mingw_clang = host_os == "Windows" and host_compiler == "clang" and \ |
There was a problem hiding this comment.
Could you please added a comment explaining why not that comes next is important for futures contributors who might not know I'd like to try avoiding breaking this again
There was a problem hiding this comment.
Maybe just add a link to conan-io/conan#12678
There was a problem hiding this comment.
Sure, "for more details see..." it good
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions. |
|
|
ghost
mentioned this pull request
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
ghost
mentioned this pull request
|
This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions. |
|
Has this PR been abandoned on purpose? We need exactly this change to get zlib (and dependent packages like Qt, boost, etc.) working with MinGW clang at our company. |
Hi @mhthies - I'm happy to pick this up again. I'll open a PR to address this as best I can - since we can't rename libraries for already published versions. |
|
For zlib recipe, unfortunately, the best approach would be to just use collect_libs() since it's may be difficult to predict lib name based on conan profile. |
closes #14440