-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glslang: add 1.3.224.0 + partial conan v2 support #12967
glslang: add 1.3.224.0 + partial conan v2 support #12967
Conversation
Also enforce target names in CMakeDeps. Since KhronosGroup/glslang#2989, glslang provides glslang-config.cmake file with CMake targets under glslang:: namespace.
All green in build 1 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* partial conan v2 support Also enforce target names in CMakeDeps. Since KhronosGroup/glslang#2989, glslang provides glslang-config.cmake file with CMake targets under glslang:: namespace. * add glslang/1.3.224.0
* partial conan v2 support Also enforce target names in CMakeDeps. Since KhronosGroup/glslang#2989, glslang provides glslang-config.cmake file with CMake targets under glslang:: namespace. * add glslang/1.3.224.0
Specify library name and version: lib/1.0
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!