adding cpprestsdk/v2.10.15 #1191

prince-chrismc · 2020-03-26T17:58:49Z

from bincrafters/conan-cpprestsdk@a322739

Specify library name and version: cpprestsdk/v2.10.15

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

The patches are very complicated, looking for guidance on how they can be improved!

from bincrafters/conan-cpprestsdk@a322739

conan-center-bot · 2020-03-26T18:21:21Z

Some configurations of 'cpprestsdk/2.10.14' failed in build 3 (70a0982ae4ea19d2c373c97da4c73131573413b8):

Linux x86_64, Release, gcc 5, libstdc++ . Options: cpprestsdk:shared-True
- Hooks errors detected:
  - [HOOK - conan-center.py] post_package(): ERROR: [CMAKE-MODULES-CONFIG-FILES (KB-H016)] The conan-center repository doesn't allow the packages to contain CMake find modules or config files. The packages have to be located using generators and the declared cpp_infoinformation (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H016)
  - [HOOK - conan-center.py] post_package(): ERROR: [CMAKE-MODULES-CONFIG-FILES (KB-H016)] Found files:
- Log download
- Log error Download
- Profile
Access to all the logs

conan-center-bot · 2020-03-27T00:01:39Z

All green in build 4 (8812016f6c8fbe40856330b35875da3da95584f7)! 😊

cpprestsdk/2.10.14: Generated 130 packages. All logs here
cpprestsdk/2.10.15: Generated 130 packages. All logs here

recipes/cpprestsdk/all/conanfile.py

Co-Authored-By: Michael "Croydon" Keck <[email protected]>

prince-chrismc · 2020-03-27T02:02:32Z

recipes/cpprestsdk/all/conanfile.py

+    def configure(self):
+        if self.settings.compiler == 'Visual Studio':
+            del self.options.fPIC


I'll drop this here...

I ran a search to see how to deleted the fPIC option... However I have seen many different way is lots of recipes.

Which way is correct?

Correct me if I'm wrong. @uilianries
In config_options(), only the settings object is finished, so you can do:

if self.settings.os == "Windows": del self.options.fPIC

In the configure() method, the options object is finished, so you can do:

if self.options.shared: del self.options.fPIC

@madebr Yes. Thus, it should be moved to config_options

@uilianries I noticed this is very inconsistent in most recipes. Could this be added to the hooks?

conan-center-bot · 2020-03-27T02:29:58Z

Failure in build 9 (091a6e73993b6928f78b428a0f3d0a63ca754db0):
cpprestsdk/2.10.14:

'conan export' command failed:

ERROR: Package recipe with version 2.10.14!=2.10.15

recipes/cpprestsdk/all/CMakeLists.txt

madebr · 2020-03-27T02:25:25Z

recipes/cpprestsdk/all/conanfile.py

+    def configure(self):
+        if self.settings.compiler == 'Visual Studio':
+            del self.options.fPIC


Correct me if I'm wrong. @uilianries
In config_options(), only the settings object is finished, so you can do:

if self.settings.os == "Windows": del self.options.fPIC

In the configure() method, the options object is finished, so you can do:

if self.options.shared: del self.options.fPIC

recipes/cpprestsdk/all/conanfile.py

recipes/cpprestsdk/all/test_package/conanfile.py

madebr · 2020-03-27T02:43:35Z

recipes/cpprestsdk/all/conanfile.py

+            self._cmake.definitions["IOS"] = True
+        elif self.settings.os == "Android":
+            self._cmake.definitions["ANDROID"] = True
+            self._cmake.definitions["CONAN_LIBCXX"] = ''


What is the reason for this?
Maybe a dependency sets wrong flags?

Copy paste from bincrafters, I have no clue =)

@SSE4
only 2 years ago
bincrafters/conan-cpprestsdk@c648cea 😈😄
Do you have any clues why this is/was needed?

I would comment the line out (+add comment) and see what happens.

From the wiki, Android is not even listed. Is supporting android require for CCI?

It is not tested by CI, but patches are accepted as mobile devices are popular these days. (What is the official stance? @uilianries)

When you think about it, the IOS and ANDROID lines can be removed as well.
See https://cmake.org/cmake/help/latest/manual/cmake-variables.7.html#variables-that-describe-the-system

When I search for the string "android" in their github cpprestsdk repo, I can find some hits.
So it is supported by the project (to some level at least)

Android support came from another contributor. Need to investigate if that recipe really requires those definitions

I have opted for removing Android. If in the future it's needed we can always revisit the topic.

recipes/cpprestsdk/all/test_package/CMakeLists.txt

Co-Authored-By: Anonymous Maarten <[email protected]>

conan-center-bot · 2020-03-27T04:09:19Z

All green in build 13 (334baa9c56cd26ba19e01607cc7c401352f5d85f)! 😊

cpprestsdk/2.10.14: Generated 130 packages. All logs here
cpprestsdk/2.10.15: Generated 130 packages. All logs here

Signed-off-by: Uilian Ries <[email protected]>

uilianries · 2020-04-02T13:27:01Z

@prince-chrismc take a look prince-chrismc#2

External patches for cpprestsdk

conan-center-bot · 2020-04-02T13:48:17Z

Some configurations of 'cpprestsdk/2.10.14' failed in build 15 (cac32213529329f463434547e5ded2da97d501dd):

Linux x86_64, Release, gcc 5, libstdc++ . Options: cpprestsdk:shared-True
Access to all the logs

conan-center-bot · 2020-04-02T13:48:43Z

Some configurations of 'cpprestsdk/2.10.14' failed in build 16 (7eb661e40df1527dbd4a1f89941ab8627107691b):

Linux x86_64, Release, gcc 5, libstdc++ . Options: cpprestsdk:shared-True
Access to all the logs

conan-center-bot · 2020-04-02T14:41:44Z

All green in build 17 (ca2e539f4e8d5eff58005901041e9e994ab82aae)! 😊

cpprestsdk/2.10.15: Generated 130 packages. All logs here

conan-center-bot · 2020-04-17T13:25:12Z

All green in build 18 (5acbdadfeff07acb23d638c2b2d52d893897bd8f)! 😊

cpprestsdk/2.10.15: Generated 130 packages. All logs here

prince-chrismc · 2020-04-23T13:05:18Z

❤️ I really appreciate the work the whole CCI team put's in to make this project a reality. 🥇 It's greatly appreciated.

@danimtb I do have a small requests for tomorrow's "PR merging session"... here's a list off oldest approved PR which many seem ready to go.
There's 10 of them dating back to beginning of February. Hopefully this helps narrow down the ones that need attention.
It's a little disheartening seeing an approved PR sit for 3 weeks and go stale 😞 while the 16 newest PRs got merged today alone. (which is freaking impressive 😮 )
Maybe having the bot or actions tag PR's 'Ready' could be helpful for you guys sort them out more?

Regardless of what you do, I am incredibly grateful for the effort from the CCI team! 💘

conan-center-bot · 2020-04-23T13:08:24Z

All green in build 19 (5acbdadfeff07acb23d638c2b2d52d893897bd8f)! 😊

cpprestsdk/2.10.15: Generated 130 packages. All logs here

danimtb · 2020-04-23T15:28:39Z

@prince-chrismc thanks a lot for the feedback. We have plans to automate ConanCenter and improve the review process involving enthusiastic users from the community like you. Of course, we will review the list of approved PRs and unblock other ones in the next wave, it just that sometimes there are so many things going on that you overlook some of the open PRs. Thanks a lot again for your contributions and for helping us review other PRs 😄

prince-chrismc added 3 commits March 26, 2020 13:56

first draft for migrating cpprestsdk/v2.10.x@bincrafters/stable to CCI

cbb59ba

from bincrafters/conan-cpprestsdk@a322739

update openssl to latest

f685d68

simplification to test_package/CMakeLists.txt

70a0982

conan-center-bot added the Failed label Mar 26, 2020

removing cmake config files for linux as well

8812016

conan-center-bot removed the Failed label Mar 27, 2020

Croydon reviewed Mar 27, 2020

View reviewed changes

recipes/cpprestsdk/all/conanfile.py Outdated Show resolved Hide resolved

Croydon reviewed Mar 27, 2020

View reviewed changes

recipes/cpprestsdk/all/conanfile.py Outdated Show resolved Hide resolved

Croydon reviewed Mar 27, 2020

View reviewed changes

recipes/cpprestsdk/all/conanfile.py Outdated Show resolved Hide resolved

Croydon reviewed Mar 27, 2020

View reviewed changes

recipes/cpprestsdk/all/conanfile.py Outdated Show resolved Hide resolved

prince-chrismc and others added 3 commits March 26, 2020 21:57

Update recipes/cpprestsdk/all/conanfile.py

5db3793

Co-Authored-By: Michael "Croydon" Keck <[email protected]>

Update recipes/cpprestsdk/all/conanfile.py

d53a201

Co-Authored-By: Michael "Croydon" Keck <[email protected]>

Update recipes/cpprestsdk/all/conanfile.py

f8e82eb

Co-Authored-By: Michael "Croydon" Keck <[email protected]>

prince-chrismc commented Mar 27, 2020

View reviewed changes

prince-chrismc added 2 commits March 26, 2020 22:18

removing Boost_ADDITIONAL_VERSIONS

846c954

removing lots of unused cmake definitions

091a6e7

conan-center-bot added the Failed label Mar 27, 2020

oops! removing version

d87eaa0

madebr reviewed Mar 27, 2020

View reviewed changes

removing vcvars from test_package

607ed81

madebr reviewed Mar 27, 2020

View reviewed changes

recipes/cpprestsdk/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved

prince-chrismc and others added 2 commits March 26, 2020 22:49

Update recipes/cpprestsdk/all/CMakeLists.txt

301e28f

Co-Authored-By: Anonymous Maarten <[email protected]>

Update recipes/cpprestsdk/all/test_package/CMakeLists.txt

334baa9

Co-Authored-By: Anonymous Maarten <[email protected]>

madebr mentioned this pull request Mar 27, 2020

Add cc65/2.18 recipe #719

Merged

4 tasks

conan-center-bot removed the Failed label Mar 27, 2020

External patches for cpprestsdk

6a08396

Signed-off-by: Uilian Ries <[email protected]>

prince-chrismc added 2 commits April 2, 2020 09:34

Merge pull request #2 from uilianries/cpprestsdk

cac3221

External patches for cpprestsdk

package option are not with_lib to be consistent with other receipes

7eb661e

conan-center-bot added the Failed label Apr 2, 2020

remove 2.10.14 from config.yml

ca2e539

conan-center-bot removed the Failed label Apr 2, 2020

uilianries previously approved these changes Apr 2, 2020

View reviewed changes

uilianries requested a review from SSE4 April 2, 2020 15:11

SSE4 previously approved these changes Apr 3, 2020

View reviewed changes

SpaceIm mentioned this pull request Apr 3, 2020

[request] some of most relevant c++ libraries in github (by number of stars) #621

Closed

uilianries mentioned this pull request Apr 7, 2020

[bug] zlib override doesn't work conan-io/conan#6812

Closed

removing add from requires

5acbdad

prince-chrismc dismissed stale reviews from SSE4 and uilianries via 5acbdad April 17, 2020 12:45

prince-chrismc requested review from uilianries and SSE4 April 17, 2020 12:45

uilianries approved these changes Apr 17, 2020

View reviewed changes

SSE4 approved these changes Apr 19, 2020

View reviewed changes

prince-chrismc changed the title ~~first draft for migrating cpprestsdk/v2.10.x@bincrafters/stable to CCI~~ adding cpprestsdk/v2.10.15 Apr 23, 2020

danimtb approved these changes Apr 23, 2020

View reviewed changes

danimtb merged commit 41f9410 into conan-io:master Apr 23, 2020

prince-chrismc deleted the add/cpprestsdk branch April 23, 2020 16:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding cpprestsdk/v2.10.15 #1191

adding cpprestsdk/v2.10.15 #1191

prince-chrismc commented Mar 26, 2020

conan-center-bot commented Mar 26, 2020

conan-center-bot commented Mar 27, 2020

prince-chrismc Mar 27, 2020

madebr Mar 27, 2020

uilianries Apr 2, 2020

prince-chrismc Apr 2, 2020

conan-center-bot commented Mar 27, 2020

madebr Mar 27, 2020

madebr Mar 27, 2020

prince-chrismc Mar 27, 2020

madebr Mar 27, 2020

prince-chrismc Mar 27, 2020

madebr Mar 27, 2020

madebr Mar 27, 2020

uilianries Apr 2, 2020

prince-chrismc Apr 2, 2020

conan-center-bot commented Mar 27, 2020

uilianries commented Apr 2, 2020

conan-center-bot commented Apr 2, 2020

conan-center-bot commented Apr 2, 2020

conan-center-bot commented Apr 2, 2020

conan-center-bot commented Apr 17, 2020

prince-chrismc commented Apr 23, 2020

conan-center-bot commented Apr 23, 2020

danimtb commented Apr 23, 2020

adding cpprestsdk/v2.10.15 #1191

adding cpprestsdk/v2.10.15 #1191

Conversation

prince-chrismc commented Mar 26, 2020

conan-center-bot commented Mar 26, 2020

conan-center-bot commented Mar 27, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

conan-center-bot commented Mar 27, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

conan-center-bot commented Mar 27, 2020

uilianries commented Apr 2, 2020

conan-center-bot commented Apr 2, 2020

conan-center-bot commented Apr 2, 2020

conan-center-bot commented Apr 2, 2020

conan-center-bot commented Apr 17, 2020

prince-chrismc commented Apr 23, 2020

conan-center-bot commented Apr 23, 2020

danimtb commented Apr 23, 2020