Configurable url and no ulimit warning #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 20, 2016 16:06
- add attributes to be able to configure download url, extension, binaries, strip_component for ark call - fixes computerlyrik#11
- set default value to 8192 to avoid warning - fixes computerlyrik#12
- add binary_name attribute - add example to kitchen file
|
The build doesn't seem to have any real errors, but rather stupid gem dependency issues that are not possibly the fault of these changes. Can we just merge this? For this to be a properly wrappable cookbook, using attributes for the |
|
@computerlyrik can this be looked at please? It's blocking me from using this cookbook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #11 and fix #12