Optimization: avoid setting role_name for each function call #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilodcn
reviewed
Nov 11, 2023
| @@ -29,8 +29,9 @@ def __init__(self, **_kwargs): | |||
| def _call_role_fn(self, fn, *args, **kwargs): | |||
| """Attempts to call a role-scoped method""" | |||
| try: | |||
| role_name = self._get_role(self.request.user) | |||
| role_fn = "{}_for_{}".format(fn, role_name) | |||
| if not getattr(self, '_role_name', None): | |||
There was a problem hiding this comment.
try using lru_cache from functools python module for result cache
https://docs.python.org/3/library/functools.html#functools.lru_cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I notice that when using the mixin, there are multiple repeated db calls to get the user's role name:
For example, I can see the following statement appearing 5 times for one request.
The reason is because
_get_role()is called for each function in theVIEWSET_METHOD_REGISTRY, which involves a call to the db each time.There is a simple performance enhancement which is to retain the
role_namevalue on the object. I cannot foresee any issues with this, since the object exists for the lifetime of the request.