Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail output comparison on unexpected output #82

Merged
merged 5 commits into from
Jan 15, 2018

Conversation

takluyver
Copy link
Member

Closes #81.

@takluyver takluyver merged commit bff46af into computationalmodelling:master Jan 15, 2018
@takluyver takluyver deleted the i81 branch January 15, 2018 13:49
@vidartf
Copy link
Collaborator

vidartf commented Jan 15, 2018

Regarding the failure in jupyter/notebook#3212, I'm guessing the reason we didn't check for added outputs previously was because it didn't allow for keeping un-run notebooks for testing. Maybe a solution is to add a check for execution_count if output was added (unless the addition is an unexpected exception)?

@vidartf
Copy link
Collaborator

vidartf commented Jan 15, 2018

Or, formulated a little better: Cells without an execution_count should implicitly be evaluated in lax mode.

@takluyver
Copy link
Member Author

That makes sense. Do you want to code it up?

@vidartf
Copy link
Collaborator

vidartf commented Jan 15, 2018

I'll submit a PR tomorrow.

@takluyver
Copy link
Member Author

takluyver commented Jan 15, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants