Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ipv4 options #7

Merged
merged 11 commits into from
Sep 18, 2024
Merged

Ipv4 options #7

merged 11 commits into from
Sep 18, 2024

Conversation

compscidr
Copy link
Owner

@compscidr compscidr commented Sep 13, 2024

Added required Ipv4 options re: https://datatracker.ietf.org/doc/html/rfc791, along with a way to process unsupported Ipv4 options with a length / size byte immediately after the (copied / type / class) byte.

Also added test coverage for these additional options.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 91.72932% with 33 lines in your changes missing coverage. Please review.

Project coverage is 94.91%. Comparing base (82f3966) to head (84ebb3b).

Files with missing lines Patch % Lines
...c/main/kotlin/com/jasonernst/knet/ip/Ipv4Header.kt 44.44% 6 Missing and 4 partials ⚠️
.../ip/options/Ipv4OptionLooseSourceAndRecordRoute.kt 88.88% 0 Missing and 5 partials ⚠️
...asonernst/knet/ip/options/Ipv4OptionRecordRoute.kt 88.88% 0 Missing and 5 partials ⚠️
...ip/options/Ipv4OptionStrictSourceAndRecordRoute.kt 88.88% 0 Missing and 5 partials ⚠️
...m/jasonernst/knet/ip/options/Ipv4OptionSecurity.kt 90.24% 3 Missing and 1 partial ⚠️
...om/jasonernst/knet/ip/options/Ipv4OptionUnknown.kt 92.59% 0 Missing and 2 partials ⚠️
...otlin/com/jasonernst/knet/ip/options/Ipv4Option.kt 98.38% 1 Missing ⚠️
...sonernst/knet/ip/options/Ipv4OptionSecurityType.kt 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main       #7      +/-   ##
============================================
+ Coverage     94.11%   94.91%   +0.80%     
- Complexity      126      219      +93     
============================================
  Files            22       35      +13     
  Lines           832     1220     +388     
  Branches         79      130      +51     
============================================
+ Hits            783     1158     +375     
+ Misses           35       27       -8     
- Partials         14       35      +21     
Flag Coverage Δ
unittests 94.91% <91.72%> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@compscidr compscidr merged commit c2fc349 into main Sep 18, 2024
1 check passed
@compscidr compscidr deleted the jason/ipv4options branch October 8, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant