Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for dates with format Ymd.minor.patch #48

Closed

Conversation

nazar-pc
Copy link

Works identical to major.minor.patch.
Fixes #32, fxpio/composer-asset-plugin#185

@nazar-pc
Copy link
Author

Can anyone look at this simple PR?

@alcohol
Copy link
Member

alcohol commented Nov 11, 2016

I am not sure if we want to keep adding more version formats. We already support semver plus a wide range of exotic less used formats. If we add every format everyone comes up with, soon a version won't carry any meaning anymore.

@nazar-pc
Copy link
Author

This is basically improving support for regular major.minor.patch, since major component is currently limited to 5 characters.

@alcohol
Copy link
Member

alcohol commented Nov 11, 2016

It is limited explicitly to 5 so that it does not overlap with the date(time) regex.

@nazar-pc
Copy link
Author

I know, but sometimes we might need to support 6 digits like in linked issues, so why not?

@alcohol
Copy link
Member

alcohol commented Nov 11, 2016

Well, that is open to discussion. As mentioned in #32, we are not really convinced that this needs "fixing".

@Seldaek is it easy to determine what the impact of this might be on the Packagist database?

@Seldaek
Copy link
Member

Seldaek commented Nov 11, 2016

No it's not easy to tell what the impact would be.. and since it just is to support an external package versioning scheme that isn't even PHP, I would tend to say it's not really our problem. The assets install plugin should make sure it provides valid version identifiers to Composer. Should be as easy as replacing dots by dashes if you see a large version number that looks like a date?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants