Fix overwrite logic as $context->negate makes $context->false return …

…false after
composer · Nov 12, 2024 · f126d9e · f126d9e
1 parent 55ce5e2
commit f126d9e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/PHPStan/PregMatchTypeSpecifyingExtension.php b/src/PHPStan/PregMatchTypeSpecifyingExtension.php
@@ -87,7 +87,9 @@ public function specifyTypes(MethodReflection $methodReflection, StaticCall $nod
             $matchedType = PregMatchFlags::removeNullFromMatches($matchedType);
         }
 
+        $overwrite = false;
         if ($context->false()) {
+            $overwrite = true;
             $context = $context->negate();
         }
 
@@ -98,6 +100,6 @@ public function specifyTypes(MethodReflection $methodReflection, StaticCall $nod
             $scope,
         )->setRootExpr($node);
 
-        return $context->false() ? $typeSpecifier->setAlwaysOverwriteTypes() : $typeSpecifier;
+        return $overwrite ? $typeSpecifier->setAlwaysOverwriteTypes() : $typeSpecifier;
     }
 }
diff --git a/src/PcreException.php b/src/PcreException.php
@@ -39,7 +39,6 @@ private static function pcreLastErrorMessage($code)
             return preg_last_error_msg();
         }
 
-        /** @var array<string, array<string, int>> $constants */
         $constants = get_defined_constants(true);
         if (!isset($constants['pcre']) || !is_array($constants['pcre'])) {
             return 'UNDEFINED_ERROR';