Fix PHPStan 2 findings

composer · Nov 12, 2024 · e06408b · e06408b
1 parent 312f023
commit e06408b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/src/PcreException.php b/src/PcreException.php
@@ -39,11 +39,7 @@ private static function pcreLastErrorMessage($code)
             return preg_last_error_msg();
         }
 
-        // older php versions did not set the code properly in all cases
-        if (PHP_VERSION_ID < 70201 && $code === 0) {
-            return 'UNDEFINED_ERROR';
-        }
-
+        /** @var array<string, array<string, int>> $constants */
         $constants = get_defined_constants(true);
         if (!isset($constants['pcre']) || !is_array($constants['pcre'])) {
             return 'UNDEFINED_ERROR';

diff --git a/tests/PHPStanTests/InvalidRegexPatternRuleTest.php b/tests/PHPStanTests/InvalidRegexPatternRuleTest.php
@@ -31,7 +31,7 @@ protected function getRule(): \PHPStan\Rules\Rule
 
     public function testRule(): void
     {
-        $missing = PHP_VERSION_ID < 70300 ? ')' : 'closing parenthesis';
+        $missing = 'closing parenthesis';
 
         $this->analyse([__DIR__ . '/fixtures/invalid-patterns.php'], [
             [