Skip to content
This repository has been archived by the owner on Oct 17, 2023. It is now read-only.

design doc with proposed changes for message and state tracking #323

Merged
merged 1 commit into from
Jun 23, 2017

Conversation

jipperinbham
Copy link
Contributor

@jipperinbham jipperinbham commented Mar 22, 2017

the plan is to leave this PR open while the implementation is occurring so we can update the doc with any specifics or changes along the way.

fixes #33

  • remove any existing code
  • reader state
  • commit log
  • writer restart
  • reader resume
  • log truncation
  • error handling

@compose compose deleted a comment from codecov bot Jun 23, 2017
@compose compose deleted a comment from codecov bot Jun 23, 2017
@compose compose deleted a comment from codecov bot Jun 23, 2017
@compose compose deleted a comment from codecov bot Jun 23, 2017
@codecov
Copy link

codecov bot commented Jun 23, 2017

Codecov Report

Merging #323 into master will increase coverage by 1.98%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
+ Coverage   84.44%   86.43%   +1.98%     
==========================================
  Files          23       59      +36     
  Lines        1183     3457    +2274     
==========================================
+ Hits          999     2988    +1989     
- Misses        123      310     +187     
- Partials       61      159      +98
Impacted Files Coverage Δ
adaptor/elasticsearch/transport.go 100% <0%> (ø)
adaptor/rabbitmq/writer.go 100% <0%> (ø)
adaptor/elasticsearch/clients/v2/writer.go 86.76% <0%> (ø)
function/rename/rename.go 100% <0%> (ø)
adaptor/rethinkdb/writer.go 86.36% <0%> (ø)
adaptor/elasticsearch/elasticsearch.go 92.1% <0%> (ø)
message/message.go 100% <0%> (ø)
pipe/pipe.go 100% <0%> (ø)
adaptor/mongodb/client.go 100% <0%> (ø)
function/omit/omitter.go 100% <0%> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9910219...d2262f0. Read the comment docs.

@jipperinbham jipperinbham merged commit d20abda into master Jun 23, 2017
@jipperinbham jipperinbham deleted the 33-design-doc branch June 23, 2017 21:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Add the ability to save and restore the state of an adaptor
1 participant